Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loginPage.js #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Farzannajipour
Copy link

No description provided.

Copy link
Owner

@zafar-saleem zafar-saleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Farzannajipour I am not sure that let must be replaced with const unless there is a good reason.

Copy link

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Farzannajipour
Copy link
Author

Sure, since these variables do not change so it should be constants and I'd rather use const instead of let

@Farzannajipour
Copy link
Author

Looks good.

Looking forward to approving it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants