sort children during export to ensure a more stable format #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm using a script to run a daily markdown export and commit the result to git for backup and to use git tools to browse history.
I'm using notes with clones and noticed that the export format is not stable. For instance, with two notes clones NoteA and NoteB, export on one day may produce NoteA.md + NoteB.clone.md and another day NoteA.clone.md + NoteB.md. This makes it harder to track history.
Looking at the code, I see that this may happen since the notes tree traversal doesn't sort the children by their
notePositionattribute. This PR callssortChildrento produce a more stable and reproducible export.