fix setNoteToParent API breakage, closes #4505

zadam · Dec 11, 2023 · 0ac397e · 0ac397e
1 parent d243880
commit 0ac397e
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/services/tree.js b/src/services/tree.js
@@ -209,8 +209,9 @@ function sortNotesIfNeeded(parentNoteId) {
 function setNoteToParent(noteId, prefix, parentNoteId) {
     const parentNote = becca.getNote(parentNoteId);
 
-    if (!parentNote) {
-        throw new Error(`Cannot move note to deleted parent note '${parentNoteId}'`);
+    if (parentNoteId && !parentNote) {
+        // null parentNoteId is a valid value
+        throw new Error(`Cannot move note to deleted / missing parent note '${parentNoteId}'`);
     }
 
     // case where there might be more such branches is ignored. It's expected there should be just one