Added more clippy lint rules (#17)

.github/workflows/pull_request.yml

@@ -72,4 +72,4 @@ jobs:
           override: true
           components: clippy
       - name: Run Clippy
-        run: cargo clippy --all-targets --all-features
+        run: cargo clippy --all-targets --all-features -- -D warnings

src/fcm.rs

@@ -70,10 +70,7 @@ pub async fn send_fcm_message<T: Serialize>(
     project_id: &str,
 ) -> Result<(), FcmError> {
     info!("Sending FCM message to device: {}", device_token);
-    let url = format!(
-        "https://fcm.googleapis.com/v1/projects/{}/messages:send",
-        project_id
-    );
+    let url = format!("https://fcm.googleapis.com/v1/projects/{project_id}/messages:send");
 
     send_fcm_message_with_url(
         device_token,

src/lib.rs

@@ -1,6 +1,17 @@
-mod error;
-mod fcm;
-mod token_manager;
+#![forbid(unsafe_code)]
+#![warn(
+    clippy::pedantic,
+    clippy::nursery,
+    clippy::tests_outside_test_module,
+    unused_qualifications,
+    non_ascii_idents
+)]
+#![allow(
+    clippy::missing_errors_doc,
+    clippy::missing_panics_doc,
+    clippy::module_name_repetitions,
+    clippy::future_not_send
+)]
 
 use std::fmt::Debug;
 use std::io::Read;
@@ -15,6 +26,10 @@ pub use token_manager::TokenManager;
 use tracing::info;
 use tracing::instrument;
 
+mod error;
+mod fcm;
+mod token_manager;
+
 /// Creates a new `SharedTokenManager`.
 ///
 /// This function is a helper for creating a `SharedTokenManager` from a given

src/token_manager.rs

@@ -78,7 +78,7 @@ impl TokenManager {
 
         let service_account_key = serde_json::from_reader(credentials)?;
 
-        Ok(TokenManager {
+        Ok(Self {
             token: None,
             expires_at: None,
             service_account_key,
@@ -113,13 +113,11 @@ impl TokenManager {
     /// needed by users.
     #[instrument(level = "debug", skip(self))]
     pub fn is_token_expired(&self) -> bool {
-        self.expires_at
-            .map(|expires_at| {
-                let expired = expires_at <= Instant::now();
-                debug!("Token expired: {}", expired);
-                expired
-            })
-            .unwrap_or(true)
+        self.expires_at.map_or(true, |expires_at| {
+            let expired = expires_at <= Instant::now();
+            debug!("Token expired: {}", expired);
+            expired
+        })
     }
 
     /// Refreshes the current OAuth token.

tests/valid_fcm_tests.rs

@@ -1,7 +1,4 @@
 use std::fs::File;
-use std::fs::{
-    self,
-};
 use std::sync::Once;
 
 use oauth_fcm::create_shared_token_manager;
@@ -123,7 +120,7 @@ async fn successful_fcm_test_from_string() {
         .with_status(200)
         .create();
 
-    let creds = fs::read_to_string("tests/mock_credentials.json").unwrap();
+    let creds = std::fs::read_to_string("tests/mock_credentials.json").unwrap();
     let shared_token_manager =
         create_shared_token_manager(creds.as_bytes()).expect("Failed to create SharedTokenManager");