fix(region): panic occured when removing post overlay

yunionio · Jan 21, 2025 · 8712735 · 8712735
1 parent 3e96ee5
commit 8712735
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/pkg/compute/models/containers.go b/pkg/compute/models/containers.go
@@ -1175,11 +1175,14 @@ func (c *SContainer) PerformRemoveVolumeMountPostOverlay(ctx context.Context, us
 
 func (c *SContainer) removePostOverlay(vmd *apis.ContainerVolumeMountDisk, ov *apis.ContainerVolumeMountDiskPostOverlay) *apis.ContainerVolumeMountDisk {
 	curOvs := vmd.PostOverlay
-	for i, cov := range curOvs {
+	resultOvs := []*apis.ContainerVolumeMountDiskPostOverlay{}
+	for i := range curOvs {
+		cov := curOvs[i]
 		if cov.IsEqual(*ov) {
-			curOvs = append(curOvs[:i], curOvs[i+1:]...)
+			continue
 		}
+		resultOvs = append(resultOvs, cov)
 	}
-	vmd.PostOverlay = curOvs
+	vmd.PostOverlay = resultOvs
 	return vmd
 }