changes to relative and simple calib file path #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support better out-of-the-box experience
|
This makes a lot of sense, can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support a better out-of-the-box experience, e.g. as described by the new ROS tutorial: http://wiki.ros.org/yujin_yrl_package/Tutorials/Running%20the%20YRL.
Background: The currently used path is absolute. For using the ROS driver without touching the source code the current file path would need to be recreated exactly, which could lead to a significant effort. Using a relative file path enables the driver to pick up calibration files located in the folder from where to the driver is executed.