Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #335 #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #335 #338

wants to merge 1 commit into from

Conversation

tenevdev
Copy link

I think this fixes the issue described in #335 when using both linkify and typographer. I intend my contribution to be similar to the behaviour of https://github.com/github/cmark-gfm/blob/6a6e335709ef68cf2c616eeaf61b09ed4c654669/extensions/autolink.c#L58

However, when using just linkify, it doesn't trigger on quotes so there will be no link created. This seems inconsistent to me but it was not part of the original issue so I'm just mentioning it.

@yuin
Copy link
Owner

yuin commented Nov 28, 2022

Official GFM spec https://github.github.com/gfm/#example-624 says:

Trailing punctuation (specifically, ?, !, ., ,, :, *, _, and ~) will not be considered part of the autolink, though they may be included in the interior of the link:

' and " is not included the list.

@yuin
Copy link
Owner

yuin commented Dec 3, 2022

github/cmark-gfm#297

@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 7, 2023
@stale stale bot closed this May 21, 2023
@yuin yuin reopened this May 30, 2023
@yuin yuin added pinned issue should not be closed by stalebot and removed stale labels May 30, 2023
@yuin yuin force-pushed the master branch 5 times, most recently from e7e4266 to a590622 Compare June 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned issue should not be closed by stalebot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants