Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync up with YUI.Test #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sync up with YUI.Test #26

wants to merge 1 commit into from

Conversation

caridy
Copy link
Member

@caridy caridy commented Mar 6, 2014

WIP / PROTOTYPE / EXPERIMENT

For some reason, this repo, and the this package got stale compared with the code in yui/src/test, this PR is suppose to get them align, and finally help to remove the code from YUI Library, making yuitest is truly stand alone project.

When looking at the diff, make sure you use ?w=1 otherwise the indentation (whitespaces) are going to mess with the diff:

https://github.com/yui/yuitest/pull/26/files?w=1

According to the YUI History File for test module, this is what has changed:

3.15.0
------

* Added test.next(fn) which returns a callback that automatically
  resumes asynchronous tests.

3.14.0
------

* Added Y.ArrayAssert.isUnique()

3.11.0
------

* Modified YUITest.hasNoKeys() to bypass Android 2.3.x prototype
  enumeration bug. (GH #949)

@cpanato
Copy link

cpanato commented Mar 6, 2014

@caridy with this we can make PR here or in YUI/src/test?like the PR we made today #25 ?

@caridy
Copy link
Member Author

caridy commented Mar 6, 2014

@ctadeu ideally we will have all upcoming PRs against this repo, but it might take some time to get this merged. As today, the copy of the code from YUI into this repo is automagic, so if you get your PR merged in YUI, we will get it here as well, but again, I don't have a specific timeline with this refactor.

@cpanato
Copy link

cpanato commented Mar 6, 2014

Ok, perfect, will submit the PR in YUI, thanks man!

* @method isUnique
* @static
*/
isUnique: function (array, comparator, message) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually wrote this one and contributed it to YUI where Lang and Array are available. I'm concerned that the following calls might break:

  • Y.Lang.isArray()
  • Y.Lang.isValue()
  • Y.Array.isUnique()

Could that happen?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a PR to your branch to remove those dependencies.

@customcommander
Copy link
Contributor

@caridy, I'm very keen on seeing this going forward. Before I saw this PR yesterday I started to do some housecleaning (jshint & yuidoc fixes, whitespaces and indentation cleaning) before doing anything major.

Do you see this as a waste of time/not big priority or complementary? Ideally I'd like to sync my efforts with yours but I'm totally fine with doing the small bits if that's the way to go.

@customcommander
Copy link
Contributor

@caridy I've made several PRs against caridy/yuitest to complement this one. Have you got any comments on those? Would you rather see them merged into one instead?

@caridy
Copy link
Member Author

caridy commented May 28, 2014

@customcommander, I'm on the road for two weeks, I will try to get a chance to work on this at some point, but it will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants