-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync up with YUI.Test
#26
base: master
Are you sure you want to change the base?
Conversation
@ctadeu ideally we will have all upcoming PRs against this repo, but it might take some time to get this merged. As today, the copy of the code from YUI into this repo is automagic, so if you get your PR merged in YUI, we will get it here as well, but again, I don't have a specific timeline with this refactor. |
Ok, perfect, will submit the PR in YUI, thanks man! |
* @method isUnique | ||
* @static | ||
*/ | ||
isUnique: function (array, comparator, message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually wrote this one and contributed it to YUI where Lang
and Array
are available. I'm concerned that the following calls might break:
- Y.Lang.isArray()
- Y.Lang.isValue()
- Y.Array.isUnique()
Could that happen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just made a PR to your branch to remove those dependencies.
@caridy, I'm very keen on seeing this going forward. Before I saw this PR yesterday I started to do some housecleaning (jshint & yuidoc fixes, whitespaces and indentation cleaning) before doing anything major. Do you see this as a waste of time/not big priority or complementary? Ideally I'd like to sync my efforts with yours but I'm totally fine with doing the small bits if that's the way to go. |
@caridy I've made several PRs against caridy/yuitest to complement this one. Have you got any comments on those? Would you rather see them merged into one instead? |
@customcommander, I'm on the road for two weeks, I will try to get a chance to work on this at some point, but it will take some time. |
WIP / PROTOTYPE / EXPERIMENT
For some reason, this repo, and the this package got stale compared with the code in
yui/src/test
, this PR is suppose to get them align, and finally help to remove the code from YUI Library, making yuitest is truly stand alone project.When looking at the diff, make sure you use ?w=1 otherwise the indentation (whitespaces) are going to mess with the diff:
https://github.com/yui/yuitest/pull/26/files?w=1
According to the YUI History File for
test
module, this is what has changed: