Fix glob option of .yeti.json

[okuryu]

It is now not use Globstar if you are also using the Globstar, because it would match up to file under node_modules directory.

[okuryu.local]([email protected])$ yeti
Found 297 files to test.
  Agent connected: Chrome (26.0.1410.65) / Mac OS from 127.0.0.1
✓ Testing started on Chrome (26.0.1410.65) / Mac OS
✗ Script error: Uncaught ReferenceError: YUI is not defined
  URL: node_modules/yogi/defaults/tests/unit/index.html
  Line: 1
  User-Agent: Chrome (26.0.1410.65) / Mac OS
✗ Script error: Uncaught ReferenceError: YUI is not defined
  URL: node_modules/yogi/defaults/tests/unit/index.html
  Line: 13
  User-Agent: Chrome (26.0.1410.65) / Mac OS

So I would like to push this against dev-master branch because this doesn't affect the source code and test code.

/cc @reid

[triptych]

@okuryu Looks like Travis had an issue with this PR, do you see the same test failure on your side?

https://travis-ci.org/yui/yui3/jobs/7430101#L1983

[okuryu]

@triptych No. I think that doesn't matter my change and this Travis CI error.

[reid]

@okuryu Thanks for submitting this patch and sorry for the delay in our response.

It looks like the proposed change would work inside the root level directory. However, the current .yeti.json file also uses the globstar pattern to limit tests to the current component.

Perhaps we can create another .yeti.json inside of src to workaround this problem? The one inside of src can be like the original except the basedir would be .. instead of .

[okuryu]

@reid Thank you for your response!

It looks like the proposed change would work inside the root level directory. However, the current .yeti.json file also uses the globstar pattern to limit tests to the current component.

I assumed .yeti.json is only for running Yeti inside the root of repository.

Perhaps we can create another .yeti.json inside of src to workaround this problem? The one inside of src can be like the original except the basedir would be .. instead of .

How about enhance options of .yeti.json file? I have an image of this approach has general versatility than adding another file. Like this:

{
    "basedir": ".",
    "glob": "**/tests/unit/*.html",
    "ignore": "node_modules/**"
}

[reid]

@okuryu Okay. I've opened yui/yeti#57 to get that feature into Yeti.

The use of two configuration files can be used to mitigate the problem in the meantime.

[okuryu]

@reid Thanks for file a ticket!

[triptych]

@okuryu can you close this issue out if it's no longer needed given @reid 's tickets?

[okuryu]

Yeah, this is no longer needed for me. Closing makes sense to me.