Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a verbose command line option. #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Satyam
Copy link

@Satyam Satyam commented Jun 26, 2013

In order to improve the signal to noise ratio of shifter,I added a verbose option to print [info] and [queue]
messages.

With this option, which defaults to false, those messages are no longer printed.

I felt those message were more useful to debug shifter itself than to those using shifter.

With less clutter on the report, the errors and warnings stand out much more.

In order to improve the signal to noise ratio of shifter,
I added a `verbose` option to print `[info]` and `[queue]`
messages.
With this option, which defaults to false, those messages
are no longer printed.
@@ -2,7 +2,7 @@
"name": "shifter",
"description": "New YUI build tool based on Gearjs, so let's shift some gears",
"author": "Dav Glass <[email protected]>",
"version": "0.4.1",
"version": "0.4.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great pull, except for this change. Generally speaking, the version number should never be touched in a pull request. It'll be modified by the maintainer when they decide to publish a release.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't realize that. I changed it so I could install it myself and try it out, then, not knowing any better, I just left it behind.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, just pointing it out. :)

Locally, npm link in the root of the package should be sufficient to test, no need to modify the version string.

On Jun 26, 2013, at 12:12 PM, Satyam wrote:

In package.json:

@@ -2,7 +2,7 @@
"name": "shifter",
"description": "New YUI build tool based on Gearjs, so let's shift some gears",
"author": "Dav Glass [email protected]",

  • "version": "0.4.1",
  • "version": "0.4.2",
    Sorry, I didn't realize that. I changed it so I could install it myself and try it out, then, not knowing any better, I just left it behind.


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants