[#255] YDSLabel SwiftUI로 리팩토링 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhDG
reviewed
Jan 16, 2024
| } | ||
| var selectedTruncationMode: Text.TruncationMode { | ||
| return Text.TruncationMode.allCases[truncationModeSelectedIndex] | ||
| } | ||
|
|
||
| public var body: some View { | ||
| StorybookPageView(sample: { | ||
| VStack { |
There was a problem hiding this comment.
없애면 string 숨기기 했을 때 텍스트를 담은 뷰가 아예 사라집니다
OhDG
reviewed
Jan 16, 2024
| struct IntOptionView: View { | ||
| struct OptionalIntOptionView: View { |
There was a problem hiding this comment.
나중에 optional값이 아닌 Int를 받는 경우가 생길 수도 있으니 기존 IntOptionView는 놔두고 새로 추가하는 것은 어떤가요?
There was a problem hiding this comment.
원래 그러려고도 했는데 사용할 때 추가하는 편이 나을 것 같아 일단 뺐습니다!
OhDG
reviewed
Jan 16, 2024
| lineBreakStrategy: NSParagraphStyle.LineBreakStrategy = .hangulWordPriority) { | ||
| public struct YDSLabel: View { | ||
| let text: String? | ||
| let style: Font |
There was a problem hiding this comment.
style이라는 이름은 오해의 소지가 있어 보입니다. 다른 이름을 생각해주세요~
There was a problem hiding this comment.
저도 처음에 style로 했었는데 style이 무슨 스타일을 의미하는지 제대로 네이밍 하는게 좋을 것 같다는 의견이 있어서 알려드렸어요!!
| @State var typoStyleSelectedIndex = 0 | ||
| @State var lineLimit: Int? = nil |
There was a problem hiding this comment.
옵셔널로 선언하면 nil로 초기화를 안해줘도 될 것 같아요
SwiftLint에서도 경고를 띄우네요
Suggested change
| @State var lineLimit: Int? = nil | |
| @State var lineLimit: Int? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
lineLimitsmultilineTextAlignmenttruncationMode,allowsTightening0은 SwiftUI에서의 lineLimits =nil과 같아lineLimits의 기본값을 nil로 설정하기 위해
IntOptionView를OptionalIntOptionView로 수정하였습니다.✍️ Description
💡 PR Point
📚 Reference
🔥 Test
Simulator Screen Recording - iPhone 15 Pro - 2024-01-16 at 03.56.30.mp4.zip