Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make unionfind to use param #1055

Merged
merged 2 commits into from
Nov 8, 2023
Merged

make unionfind to use param #1055

merged 2 commits into from
Nov 8, 2023

Conversation

yosupo06
Copy link
Owner

@yosupo06 yosupo06 commented Nov 8, 2023

Unionfindがparamsを使うようにしました

maspypy
maspypy approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@maspypy maspypy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert(N==Q) が入っているのが、問題はないと思いますが、意図は分かりにくい気がします（修正前の時点から）。
特に N_MAX, Q_MAX を使うなら、分かりにくいかもしれません。

あとは良さそうです。

@yosupo06
Copy link
Owner Author

yosupo06 commented Nov 8, 2023

ありがとうございます、min(N, Q)を使うように書き換えました

@yosupo06 yosupo06 merged commit 75e8e5e into master Nov 8, 2023
5 checks passed
@yosupo06 yosupo06 deleted the refactor/unionfind branch November 12, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maspypy maspypy maspypy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yosupo06 @maspypy