Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to optional Security Requirements and top-level inheritance #310

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Lucien
Copy link

@Lucien Lucien commented Sep 2, 2022

  • Adds support for optional security requirements fixing a crash.
  • Adds support for top-level security requirements inheritance and overriding.

Top-Level:

Screen Shot 2022-09-02 at 18 47 33

Operation:

Screen Shot 2022-09-02 at 18 21 40

Crash

When parsing a security requirement that included an empty array (optional marker), SwagGen was crashing.

Screen Shot 2022-08-17 at 19 40 20

Swagger/SecurityRequirement.swift:9: Fatal error: Unexpectedly found nil while unwrapping an Optional value

Screen Shot 2022-08-17 at 19 25 40

@Lucien Lucien marked this pull request as ready for review September 2, 2022 22:00
arasan01 pushed a commit to bitkey-oss/SwagGen that referenced this pull request Apr 5, 2023
Add support to optional Security Requirements and top-level inheritance yonaskolb#310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant