Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes goliath hide boat able to survive liquid plasma #22789

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Oblisk234
Copy link
Member

@Oblisk234 Oblisk234 commented Nov 3, 2024

Fixes #22752 (technically)

Document the changes in your pull request

Changes the flags on the goliath hide boat to be usable in liquid plasma rivers.

Why is this good for the game?

As of current, there is no safe way of crossing plasma rivers without using bluespace shelters or RCDs at all. This way there is a proper one and it is reasonable.

Testing

image
image

Changelog

🆑
tweak: Changes the goliath hide boat to be plasma-proof.
/:cl:

@Yogbot-13 Yogbot-13 added the Feature This adds new content to the game label Nov 3, 2024
@Scrambledeggs00
Copy link
Contributor

  • PR says adds plasma boat

  • Looks inside

  • Boat not made of plasma

image

@Oblisk234
Copy link
Member Author

  • PR says adds plasma boat
  • Looks inside
  • Boat not made of plasma

image

Right, clearly I should make the boat require scooping plasma out of the river and you make it that way.

@N3D6
Copy link
Contributor

N3D6 commented Nov 3, 2024

You should atleast try and make the sprite more white since it’s polar bear hide

@Oblisk234
Copy link
Member Author

You should atleast try and make the sprite more white since it’s polar bear hide

I am not a spriter and have zero idea how to do this.

@AMyriad
Copy link
Contributor

AMyriad commented Nov 3, 2024

Fixes #22752 (technically)

The issue is regular lava boats don't have FREEZE_PROOF in its resistance_flags

image

it may be a whole of a lot simpler to just fix that than add a whole new crafting recipe that can only be used on one map

@Arachnid-Ass-Pics
Copy link

The way I got goliath plates in iceland was from plasma river fishing since it's still an lava loot table.. Also, I'm pretty sure that polar bear hide can be used for everything that goliath plates can be used for besides repairing the goliath shield. Thanks for fixing this.

@Oblisk234 Oblisk234 changed the title Adds plasma boat recipe Makes goliath hide boat able to survive liquid plasma Nov 5, 2024
@Oblisk234 Oblisk234 added Tweak This PR contains changes to the game. and removed Feature This adds new content to the game labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tweak This PR contains changes to the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lava Boat Does Not Protect From Liquid Plasma
6 participants