Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services: Fix event summary #182

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Services: Fix event summary #182

merged 2 commits into from
Dec 12, 2024

Conversation

iLLiCiTiT
Copy link
Member

Changelog Description

Don't set event summary in case of failed creation of ftrack session.

Testing notes:

  1. Set invalid server ftrack url in settings.
  2. Run services.
  3. They should crash and create event without any issues.

@iLLiCiTiT iLLiCiTiT self-assigned this Dec 11, 2024
@iLLiCiTiT iLLiCiTiT added the type: bug Something isn't working label Dec 11, 2024
@iLLiCiTiT iLLiCiTiT requested review from 64qam and MilaKudr December 11, 2024 17:16
@iLLiCiTiT iLLiCiTiT merged commit 94d1ba0 into develop Dec 12, 2024
5 checks passed
@iLLiCiTiT iLLiCiTiT deleted the bugfix/fix-event-summary branch December 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64qam 64qam 64qam approved these changes

@MilaKudr MilaKudr Awaiting requested review from MilaKudr

Assignees

@iLLiCiTiT iLLiCiTiT

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iLLiCiTiT @64qam