Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CollectTimelineInstances settings to CollectShot. (fix xml_preset_attrs_from_comments in collect_shots). #49

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Rename CollectTimelineInstances settings to CollectShot. (fix xml_preset_attrs_from_comments in collect_shots). #49

wants to merge 3 commits into from

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Jan 20, 2025 •
edited
Loading

Changelog Description

This fixes the following issue:
publish-report-250120-13-49 (1).json

Since the settings category have been renamed, I've also added a the setting conversion mechanism.

Testing notes:

  1. Tested the logic in our local Flame station
  2. Ensure the settings copy mechanism worked by re-uploading the package locally

@robin-ynput robin-ynput self-assigned this Jan 20, 2025
@robin-ynput robin-ynput added the type: bug Something isn't working label Jan 20, 2025
@robin-ynput
Copy link
Contributor Author

robin-ynput commented Jan 20, 2025 •
edited
Loading

@jakubjezek001 since we are renaming the settings here.
I'm wondering, do we have a mechanism in AYON to ease the copy/paste of those settings from one bundle to another ?

EDIT: This has been added to this PR.

jakubjezek001
jakubjezek001 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not able to test it but the code looks fine

@robin-ynput robin-ynput changed the title Fix xml_preset_attrs_from_comments in collect_shots. Rename CollectTimelineInstances settings to CollectShot. (fix xml_preset_attrs_from_comments in collect_shots). Jan 21, 2025
@robin-ynput robin-ynput requested a review from iLLiCiTiT January 22, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@robin-ynput robin-ynput

Labels
bump minor type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robin-ynput @jakubjezek001 @iLLiCiTiT