Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OTIO sequence export. #45

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Fix OTIO sequence export. #45

merged 4 commits into from
Jan 8, 2025

Conversation

robin-ynput
Copy link
Contributor

@robin-ynput robin-ynput commented Dec 17, 2024 •
edited
Loading

Changelog Description

Fix bug where media path ending with numbers get detected as sequence media.

Additional review information

Issue reported on our discord (private link).
https://discord.com/channels/517362899170230292/1272886803585826869

While doing this I realized that still image are not supported by our publisher right now (out of the scope of this PR).

Testing notes:

(tested on our own Flame instance and also client one with their content/timeline 30+ clips)

  1. Import a media finishing with a number e.g. foo.2024_01.mov in the Flame timeline
  2. Try to publish a shot/clip from it
  3. Ensure publish goes through correctly

@robin-ynput robin-ynput self-assigned this Dec 17, 2024
@robin-ynput robin-ynput added type: bug Something isn't working sponsored This is directly sponsored by a client or community member labels Dec 17, 2024
@robin-ynput robin-ynput marked this pull request as ready for review December 17, 2024 22:06
jakubjezek001
jakubjezek001 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code seems to be ok lets merge it

@robin-ynput robin-ynput merged commit f5ea796 into develop Jan 8, 2025
1 check passed
@robin-ynput robin-ynput deleted the bugfix/fix_otio_sequence_export branch January 10, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iLLiCiTiT iLLiCiTiT iLLiCiTiT left review comments

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Assignees

@robin-ynput robin-ynput

Labels
sponsored This is directly sponsored by a client or community member type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robin-ynput @jakubjezek001 @iLLiCiTiT