Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] torsten-master from metrumresearchgroup:torsten-master #4

Open
wants to merge 1,854 commits into
base: torsten-master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1854 commits
Select commit Hold shift + click to select a range
a0d4a75
Add missing header
WardBrian Sep 22, 2022
58631ee
Merge branch 'feature/2815-vectorize-conj' of github.com:stan-dev/mat…
WardBrian Sep 22, 2022
51a381c
grammer fixes for getting_started.md
SteveBronder Sep 22, 2022
142b09c
Merge pull request #2805 from stan-dev/fix/docs2
rok-cesnovar Sep 27, 2022
9b393df
Fix missing link in readme
jgabry Sep 29, 2022
cd60e75
Merge pull request #2817 from stan-dev/feature/2815-vectorize-conj
WardBrian Sep 29, 2022
b500cb6
Merge branch 'develop' of https://github.com/stan-dev/math into develop
Franzi2114 Sep 30, 2022
d001ad3
variadic wrapper for algebra_solver_powell
charlesm93 Oct 2, 2022
2d4cba7
update tests which return a var theta.
charlesm93 Oct 2, 2022
67a1a9d
ci: add minimum GitHub token permissions for workflows
ashishkurmi Oct 2, 2022
bb4c26c
update tests for algebra_solver_powell.
charlesm93 Oct 2, 2022
fe9ed26
update doxygen doc for algebra_powell.
charlesm93 Oct 3, 2022
0899fd8
update Newton solver and tests.
charlesm93 Oct 3, 2022
9f17ca2
rename algebra_solver_test to algebra_solver_powell_test
charlesm93 Oct 3, 2022
5fb3285
clean code according to cpplint.
charlesm93 Oct 3, 2022
f8b20cd
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 3, 2022
3003cb5
remove redundant test name and fix signature in fp test.
charlesm93 Oct 5, 2022
cbe1dd2
Merge branch 'feature/issue-2828-algebra_solver_variadic' of https://…
charlesm93 Oct 5, 2022
7a96a6a
Patch Eigen to resolve FFT forward derivative issue
WardBrian Oct 7, 2022
05b412b
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 7, 2022
2522546
Remove or update wiki links
WardBrian Oct 7, 2022
32ef610
Move developer guide to top of docs toc
WardBrian Oct 7, 2022
9f68a6a
Merge pull request #2821 from stan-dev/fix/fft-forward-derivatives
WardBrian Oct 8, 2022
aa9f765
clean up comments.
charlesm93 Oct 11, 2022
dff170c
Merge pull request #2823 from stan-dev/fix/docs-links
WardBrian Oct 11, 2022
5ed350a
Add std_normal_qf to ignored expression tests
WardBrian Oct 13, 2022
7a2c3b1
Merge pull request #2824 from stan-dev/tests/expression-tests-ignored…
WardBrian Oct 14, 2022
1382f3f
Expression tests: std_normal_log_qf requires non-positive argument
WardBrian Oct 14, 2022
ca7ae52
Merge pull request #2825 from stan-dev/test/std_normal_log_qf-argumen…
WardBrian Oct 15, 2022
b3da945
Merge pull request #2819 from boahc077/github_actions_token_permission
WardBrian Oct 18, 2022
22c4035
rename algebra_solver_powell --> solve_powell.
charlesm93 Oct 19, 2022
f147030
Merge commit 'b3da94556624b25a79c81343b3488aa8d65de853' into HEAD
yashikno Oct 19, 2022
3d69d1b
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 19, 2022
709e576
add unit tests for (soon to be) deprecated signatures.
charlesm93 Oct 19, 2022
2dabf8e
resolve conflict.
charlesm93 Oct 19, 2022
24503cf
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 19, 2022
8ffd677
update algebra_solver_fp_test
charlesm93 Oct 19, 2022
519e1ce
Merge branch 'feature/issue-2828-algebra_solver_variadic' of https://…
charlesm93 Oct 19, 2022
da9b25f
prim impl
andrjohns Oct 19, 2022
bb69b2f
mix tests
andrjohns Oct 19, 2022
5d7db18
Update doc
andrjohns Oct 19, 2022
85a2ea1
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 20, 2022
059e21f
Merge pull request #2806 from stan-dev/feature/log_inv_logit
SteveBronder Oct 20, 2022
4d2b936
Merge pull request #2829 from andrjohns/log_sum_exp-signed
andrjohns Oct 20, 2022
53a02e3
Merge branch 'develop' into hyper3f2-expose
andrjohns Oct 21, 2022
864f65f
Update doc, use log_sum_exp_signed
andrjohns Oct 21, 2022
5499829
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 21, 2022
9b55808
Update doc
andrjohns Oct 21, 2022
b83868c
Update atan2_test.cpp
spinkney Oct 22, 2022
12bf4e0
Merge commit '4d2b936d6686586376bbc8a99ecdf7c0937c251f' into HEAD
yashikno Oct 22, 2022
c9c5e9f
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 22, 2022
4575585
Update missing doc
andrjohns Oct 22, 2022
c4b0717
Merge pull request #2797 from andrjohns/hyper3f2-expose
andrjohns Oct 23, 2022
665f1ab
operands_and_partials for 8 parameters
Franzi2114 Oct 24, 2022
bbdd1fb
Merge branch 'stan-dev:develop' into feature/issue-2682-operands-and-…
Franzi2114 Oct 24, 2022
10c4144
hcubature added
Franzi2114 Oct 24, 2022
0a53c7d
Improve CI times (#2826)
WardBrian Oct 24, 2022
4c3fbaa
Add a pre-test stage to test changed files first
WardBrian Oct 24, 2022
6b65891
Debug changes to test
WardBrian Oct 24, 2022
1260b24
Don't fail if no tests changed
WardBrian Oct 24, 2022
b9e2179
hcubature tests added
Franzi2114 Oct 25, 2022
342d36b
added 1d example
Franzi2114 Oct 25, 2022
2302cd8
clang
Franzi2114 Oct 25, 2022
46c9fa0
Allow printing of tuples
WardBrian Oct 25, 2022
224e581
Tests: Fix sporadic failures to find `docker` (#2836)
WardBrian Oct 25, 2022
ba633b0
Merge branch 'develop' into feature/2709-print-tuples
WardBrian Oct 25, 2022
34f535f
Merge branch 'develop' into tests/prioritize-changed-tests
WardBrian Oct 25, 2022
d03f7bf
Tests and doku for hcubature finished
Franzi2114 Oct 25, 2022
fc7ed1f
corrected EXPECT_NEAR error
Franzi2114 Oct 26, 2022
faffb4a
Merge pull request #2835 from stan-dev/feature/2709-print-tuples
WardBrian Oct 26, 2022
e96f8c9
n changed to dim
Franzi2114 Oct 27, 2022
a1ccf55
hcubature: removed swaps
Franzi2114 Oct 27, 2022
b5ef176
hcubature: not used templates removed
Franzi2114 Oct 27, 2022
48e5882
all other n changed to dim
Franzi2114 Oct 27, 2022
eeb9b13
some allocs changed into vectors
Franzi2114 Oct 27, 2022
39a2855
Merge pull request #2812 from stan-dev/vectorize-atan2
spinkney Oct 27, 2022
4c4d936
drop impl functions for powell and update tests.
charlesm93 Oct 28, 2022
34169a6
update solve_newton argument ordering.
charlesm93 Oct 28, 2022
34899e7
update fixed point test.
charlesm93 Oct 28, 2022
b11afe6
correct solve_newton for make cpplint
charlesm93 Oct 28, 2022
20b6f5e
Merge commit '39a2855aff11070061b2541bae7ffe31b65e102b' into HEAD
yashikno Oct 28, 2022
a88e494
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Oct 28, 2022
4d48730
Merge pull request #2820 from stan-dev/feature/issue-2828-algebra_sol…
WardBrian Oct 31, 2022
b0c6159
Allow stan::math::minus on std::vectors
WardBrian Nov 1, 2022
5522b9d
Fix test typo
WardBrian Nov 1, 2022
f4c6817
Merge pull request #2840 from stan-dev/feature/vectorize-minus
WardBrian Nov 2, 2022
0e75989
includes, constexpr, size_t, curly brackets, choose_dimk, newlines, B…
Franzi2114 Nov 8, 2022
4daf9a8
Moved from multiset to priority_queue. Changed ordering
vpratz Nov 8, 2022
17aca6f
Merge branch 'feature/issue-2682-hcubature' of github.com:Franzi2114/…
Franzi2114 Nov 9, 2022
498b84f
new names in test
Franzi2114 Nov 9, 2022
15b4a4f
numevals, maxEval
Franzi2114 Nov 10, 2022
745a4d7
clang-format
Franzi2114 Nov 10, 2022
be5ebee
#include <vector>
Franzi2114 Nov 10, 2022
4110240
inline functions
Franzi2114 Nov 10, 2022
b0dfd01
Merge commit 'f4c68170c1f1e9bc1284520560204ea9e76c62cd' into HEAD
yashikno Nov 10, 2022
5503e3a
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Nov 10, 2022
46a2c77
no comments, no structs out + GenzMalik, Docu, one ifelse in while
Franzi2114 Nov 11, 2022
09676e5
Add overloads to eigendecomposition for complex matrices
WardBrian Nov 14, 2022
438d434
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Nov 14, 2022
c75ea8a
Add doxy comments
WardBrian Nov 17, 2022
dff9af0
release/v: updating version numbers
serban-nicusor-toptal Nov 18, 2022
8e06d02
Merge pull request #2849 from stan-dev/release/update-version
WardBrian Nov 18, 2022
72289e4
changed ordering, deleted if {break}
Franzi2114 Nov 23, 2022
022e3f6
Merge commit '8e06d02d99453332289147369fabef8c39aa3546' into HEAD
yashikno Nov 23, 2022
c9132c9
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Nov 23, 2022
95abd90
release/v4.5.0: updating version numbers (#2850)
serban-nicusor-toptal Nov 23, 2022
a6b1da6
Merge remote-tracking branch 'upstream/develop' into feature/2733-com…
andrjohns Dec 12, 2022
3cbf8e1
Merge pull request #2833 from Franzi2114/feature/issue-2682-operands-…
andrjohns Jan 2, 2023
3365dbb
Docu for hcubature internal functions
Franzi2114 Jan 2, 2023
7bcea19
Run OpenCL tests on alternative jenkins GPU
andrjohns Jan 6, 2023
b81726c
Revert Jenkinsfile change
andrjohns Jan 17, 2023
82c9f1f
Merge branch 'stan-dev:develop' into feature/issue-2682-hcubature
Franzi2114 Jan 18, 2023
cc3ab2c
Change label from v100 to k40 for OpenCL GPU tests (#2862)
serban-nicusor-toptal Jan 19, 2023
692de50
Merge branch 'stan-dev:develop' into feature/issue-2682-hcubature
Franzi2114 Jan 19, 2023
2f6f426
Merge pull request #2832 from stan-dev/tests/prioritize-changed-tests
WardBrian Jan 19, 2023
15bf01a
Dummy change
WardBrian Jan 19, 2023
5a68d8d
Revert
WardBrian Jan 19, 2023
dba14e7
updating test/prob/bernoulli includes
syclik Jan 19, 2023
c511cc2
Test
WardBrian Jan 19, 2023
f42ace5
Merge branch 'dependencies-dist-tests' of github.com:stan-dev/math in…
WardBrian Jan 19, 2023
969e65b
Change file
WardBrian Jan 19, 2023
e4988db
Add getDependencies
WardBrian Jan 19, 2023
464c72f
Update jenkinsfile
WardBrian Jan 19, 2023
b9c5aae
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Jan 19, 2023
9962496
Comment out much of jenkinsfile
WardBrian Jan 19, 2023
5273c60
Merge branch 'dependencies-dist-tests' of github.com:stan-dev/math in…
WardBrian Jan 19, 2023
aef5820
Comment out much of jenkinsfile
WardBrian Jan 19, 2023
5b46a02
updating test/prob/beta includes
syclik Jan 19, 2023
e96c7be
updating test/prob/beta_binomial includes
syclik Jan 19, 2023
4eb31a8
updating test/prob/beta_proportion includes
syclik Jan 19, 2023
a5a7969
Comment out jenkinsfile
WardBrian Jan 19, 2023
a87a384
Use python3
WardBrian Jan 19, 2023
195bd63
Fix syntax
WardBrian Jan 19, 2023
f44d4c6
updating test/prob/binomial includes
syclik Jan 19, 2023
f34c349
Need to run the dependencies step in docker
WardBrian Jan 19, 2023
487bf5b
Merge branch 'dependencies-dist-tests' of github.com:stan-dev/math in…
WardBrian Jan 19, 2023
9b749b2
Split detecting and running tests
WardBrian Jan 20, 2023
66ed10f
Re-enable jenkinsfile, add develop/master logic and override
WardBrian Jan 20, 2023
47b5bfd
Divide up more
WardBrian Jan 20, 2023
db09f10
Revert dummy change
WardBrian Jan 20, 2023
21027d2
Flip conditional
WardBrian Jan 20, 2023
f47762d
updating test/prob/cauchy includes
syclik Jan 20, 2023
b8010db
updating test/prob/chi_square
syclik Jan 20, 2023
32f1c1c
updating test/prob/discrete_range
syclik Jan 20, 2023
239fd36
updating test/prob/double_exponential
syclik Jan 20, 2023
003c7ff
updating test/prob/exponential
syclik Jan 20, 2023
a80916f
updating test/prob/frechet
syclik Jan 20, 2023
cf82c25
updating test/prob/gamma
syclik Jan 20, 2023
bc40da2
updating test/prob/hypergeometric
syclik Jan 20, 2023
1e5baa8
updating test/prob/gumbel
syclik Jan 20, 2023
03fe26a
updating test/prob/inv_chi_square
syclik Jan 20, 2023
d0ac92f
updating test/prob/inv_gamma
syclik Jan 20, 2023
cf613aa
updating test/prob/exp_mod_normal
syclik Jan 20, 2023
42bdd05
updating test/prob/logistic
syclik Jan 20, 2023
849da26
updating test/prob/loglogistic
syclik Jan 20, 2023
3bd493a
updating test/prob/lognormal
syclik Jan 20, 2023
66601e9
updating test/prob/neg_binomial
syclik Jan 20, 2023
9bd3177
updating test/prob/neg_binomial_2
syclik Jan 20, 2023
a6e5454
updating test/prob/normal
syclik Jan 20, 2023
667cfa9
updating test/prob/normal_sufficient
syclik Jan 20, 2023
3760631
updating test/prob/pareto
syclik Jan 20, 2023
6576960
updating test/prob/pareto_type_2
syclik Jan 20, 2023
33003e1
updating test/prob/poisson
syclik Jan 20, 2023
4815094
updating test/prob/rayleigh
syclik Jan 20, 2023
85081e7
updating test/prob/scaled_inv_chi_square
syclik Jan 20, 2023
f9593d8
updating test/prob/skew_double_exponential
syclik Jan 20, 2023
f8d843f
updating test/prob/std_normal
syclik Jan 20, 2023
ab0556b
updating test/prob/skew_normal
syclik Jan 20, 2023
0bcd5a6
updating test/prob/student_t
syclik Jan 20, 2023
1975d87
updating test/prob/uniform
syclik Jan 20, 2023
d36111a
updating test/prob/von_mises
syclik Jan 20, 2023
cdc40b4
updating test/prob/weibull
syclik Jan 20, 2023
647472d
updating test/prob/wiener
syclik Jan 21, 2023
e4f3876
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Jan 21, 2023
5c6f31f
Define git author and commiter information as environment variables (…
serban-nicusor-toptal Jan 21, 2023
72a3417
Merge branch 'develop' into dependencies-dist-tests
WardBrian Jan 23, 2023
92045a9
Revert "Change label from v100 to k40 for OpenCL GPU tests (#2862)" (…
WardBrian Jan 24, 2023
bc24291
Merge branch 'develop' into dependencies-dist-tests
syclik Jan 25, 2023
03f68a6
Comment out OpenCL GPU tests stage (#2867)
serban-nicusor-toptal Jan 26, 2023
5008b61
Re-enable OpenCL tests (#2868)
WardBrian Jan 26, 2023
ff81abd
Merge branch 'develop' into dependencies-dist-tests
WardBrian Jan 26, 2023
14dbb1b
Merge branch 'stan-dev:develop' into feature/issue-2682-hcubature
Franzi2114 Jan 27, 2023
8d3845e
Merge pull request #2838 from Franzi2114/feature/issue-2682-hcubature
andrjohns Jan 27, 2023
f154fea
Merge pull request #2864 from stan-dev/dependencies-dist-tests
syclik Jan 27, 2023
c5d8790
Merge branch 'develop' into feature/2733-complex-eigendecomposition
WardBrian Jan 30, 2023
86a7275
Explicitly test for empty distribution test changelist
WardBrian Jan 30, 2023
1d8e47c
Debug
WardBrian Jan 30, 2023
29171c6
Revert debug, problem solved
WardBrian Jan 30, 2023
9149f05
Merge pull request #2869 from stan-dev/tests/empty-distribution-chang…
WardBrian Jan 31, 2023
2004134
Merge branch 'develop' into feature/2733-complex-eigendecomposition
WardBrian Jan 31, 2023
abaf960
Specialize is_nan for ints
WardBrian Feb 1, 2023
8c4e644
Merge pull request #2870 from stan-dev/fix/is-nan-int
WardBrian Feb 2, 2023
92b9132
fixing sundials
syclik Jan 4, 2023
aa80c42
renaming LIBSUNDIALS to SUNDIALS_TARGETS; note: non-breaking change
syclik Jan 19, 2023
ab84dfd
make: fixing missing parens
syclik Feb 3, 2023
2205e78
adding back LIBSUNDIALS variable with a note to remove it in the future
syclik Feb 6, 2023
bc3a33e
Explicit return types, improved testing
WardBrian Feb 6, 2023
d6a93b7
Bump n1hility/cancel-previous-runs from 2 to 3
dependabot[bot] Feb 6, 2023
133fd01
Merge pull request #2861 from stan-dev/feature/libsundials
syclik Feb 7, 2023
edfc5b8
Merge pull request #2846 from stan-dev/feature/2733-complex-eigendeco…
WardBrian Feb 13, 2023
e780d49
Add failing test for matrix with empty first row
torsti Mar 1, 2023
90a5bfe
Skip processing of empty rows
torsti Mar 1, 2023
48e9738
Delete object files after test executable is built
WardBrian Mar 1, 2023
4c3441b
Merge pull request #2877 from torsti/feature/issue-2876-csr-index
WardBrian Mar 2, 2023
b86d522
make: change test target to build the .o implicitly
syclik Mar 2, 2023
96816b0
Revert "make: change test target to build the .o implicitly"
WardBrian Mar 2, 2023
59d4f02
Manually mark test object files as intermediates
WardBrian Mar 2, 2023
60af505
Update varmat_compatibility to build exe rather than .o
WardBrian Mar 2, 2023
64dadab
Revert "Update varmat_compatibility to build exe rather than .o"
WardBrian Mar 2, 2023
784eb80
Re-allow direct building of .o files with filter-out
WardBrian Mar 2, 2023
003f4aa
Also ignore .d targets for object intermediate purposes
WardBrian Mar 2, 2023
9ef7c16
Use the fact that tests end in _test in pattern
WardBrian Mar 3, 2023
0b91aa8
Merge pull request #2878 from stan-dev/tests/clean-object-files
WardBrian Mar 3, 2023
9bf7661
Delete dir in parallel distribution tests
WardBrian Mar 6, 2023
e88e487
Syntax fix
WardBrian Mar 6, 2023
f3677e8
Debug: skip early stages
WardBrian Mar 6, 2023
6ed500e
Revert "Debug: skip early stages"
WardBrian Mar 6, 2023
b34a81b
Merge pull request #2880 from stan-dev/ci/parallel-distribution-delet…
WardBrian Mar 7, 2023
d3f42be
Update to Eigen 3.4 (#2583)
SteveBronder Mar 10, 2023
98117fa
Merge pull request #2871 from stan-dev/dependabot/github_actions/n1hi…
WardBrian Mar 13, 2023
c49e8ae
Fix eigenvalues_sym return type
WardBrian Mar 24, 2023
100182e
Change an auto to a vector so compiler checks this change
WardBrian Mar 24, 2023
af4b845
make: remove unused LIBSUNDIALS
WardBrian Mar 24, 2023
f6cb7da
Merge pull request #2885 from stan-dev/cleanup/libsundials
WardBrian Mar 24, 2023
4fdc43b
Merge pull request #2884 from stan-dev/fix/2883-eigenvalues-sym-retur…
WardBrian Mar 24, 2023
cc6fc2a
Update vector type for backwards compat
andrjohns Mar 27, 2023
6cd15b8
Merge pull request #2887 from stan-dev/eigen339-compat
WardBrian Mar 28, 2023
e9fa216
Backport tbb fix for building on gcc 13
WardBrian Apr 19, 2023
2c6431d
Merge pull request #2890 from stan-dev/fix/tbb-gcc13-build
WardBrian Apr 20, 2023
6de29fe
release/v4.6.0: updating version numbers
Apr 20, 2023
b6020de
Release/v4.6.1 (#2893)
serban-nicusor-toptal May 2, 2023
bccec8f
Merge release/v4.6.2 into master (#2912)
serban-nicusor-toptal Jun 20, 2023
e20aa20
Merge release v4.7.0 into master (#2941)
serban-nicusor-toptal Sep 6, 2023
b627317
pull in torsten-specific build setups
yizhang-yiz Oct 20, 2023
9b933fb
using new macro names in torsten makefile
yizhang-yiz Oct 22, 2023
8cff781
Merge branch 'v4.7.0.torsten' into torsten-develop
yizhang-yiz Oct 25, 2023
f6be783
update torsten submodule
yizhang-yiz Oct 25, 2023
9565f4c
update github action for torsten unit testing
yizhang-yiz Oct 26, 2023
41c492d
update submodule
yizhang-yiz Oct 26, 2023
ad4b366
update submodule
yizhang-yiz Oct 26, 2023
8dd7ac6
update test gha
Jan 25, 2024
4753f45
test on macos 13
Jan 25, 2024
6593d7c
udpate gha workflow package version
Jan 25, 2024
842a96d
update submodule
Mar 4, 2024
9972fd6
Merge branch 'torsten-workflow' into torsten-develop
Mar 4, 2024
98df989
use macos-latest for model test
Mar 4, 2024
b7b7f64
update torsten_math submodule
May 20, 2024
bea4ee6
update torsten_math submodule
May 20, 2024
69b1659
update torsten submodule version
Oct 22, 2024
776fc26
use macos-13 runner instead of the latest
Oct 22, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
2,161 changes: 2,161 additions & 0 deletions .git-blame-ignore-revs

Large diffs are not rendered by default.

11 changes: 5 additions & 6 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@

Thanks for reading! We love contributions from everyone in the form of good discussion, issues, and pull requests.

This is the short version. There's more information on the [wiki](https://github.com/stan-dev/math/wiki/Developer-Doc#contributing).

This is the short version. There's more information on the [documentation site](https://mc-stan.org/math/developer_guide.html).
## Issues

We reserve [issues](https://github.com/stan-dev/math/issues) for bugs and feature requests that are defined well enough for a developer to tackle. If you have general questions about the Math library, please see the [Discussion](#discussion) section.
Expand Down Expand Up @@ -31,22 +30,22 @@ Open feature requests should be the ones we want to implement in the Math librar

## Pull Requests

All changes to the Math library are handled through [pull requests](https://github.com/stan-dev/math/pulls). Each pull request should correspond to an issue. We follow a [modified GitFlow branching model](https://github.com/stan-dev/stan/wiki/Dev:-Git-Process) for development.
All changes to the Math library are handled through [pull requests](https://github.com/stan-dev/math/pulls). Each pull request should correspond to an issue. We follow a [modified GitFlow branching model](https://github.com/stan-dev/stan/wiki/Developer-process-overview#2-create-a-branch-for-the-issue) for development.

When a contributor creates a pull request for inclusion to the Math library, here are some of the things we expect:

1. the contribution maintains the Math library's open-source [license](https://github.com/stan-dev/math/wiki/Developer-Doc#licensing): 3-clause BSD
1. the contribution maintains the Math library's open-source [license](https://github.com/stan-dev/stan/wiki/Stan-Licensing): 3-clause BSD
2. the code base remains stable after merging the pull request; we expect the `develop` branch to always be in a good state
3. the changes are maintainable. In code review, we look at the design of the proposed code. We also expect documentation. It should look like idiomatic C++.
4. the changes are tested. For bugs, we expect at least one test that fails before the patch and is fixed after the patch. For new features, we expect at least one test that shows expected behavior and one test that shows the behavior when there's an error.
5. the changes adhere to the Math library's [C++ standards](https://github.com/stan-dev/stan/wiki/Code-Quality). Consistency really helps.
5. the changes adhere to the Math library's [C++ standards](https://github.com/stan-dev/stan/wiki/Coding-Style-and-Idioms). Consistency really helps.

Pull requests are code reviewed after they pass our continuous integration tests. We expect all the above before a pull request is merged. We are an open-source project and once code makes it into the repository, it's on the community to maintain.

It is the responsibility of the contributor submitting the pull request that the code meets these requirements. We're open-source. Once the code gets into the code base, the community of developers take ownership of it.

### Code Reviews
See the [Code Review Guidelines](https://github.com/stan-dev/math/wiki/Developer-Doc#code-review-guidelines) on the Math wiki.
See the [Code Review Guidelines](https://github.com/stan-dev/stan/wiki/Developer-process-overview#code-review-guidelines) on the Math wiki.


## Discussion
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ If this is a **feature request**, show what you expect to happen if the feature


#### Current Version:
v4.1.0
v4.7.0
4 changes: 2 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Thanks for submitting a pull request! Please remove this text when submitting.

Start by filling in the Summary, Tests, and Side Effects sections of this pull request and then work through the handy checklist at the bottom. If anything significant is missing, the pull request may be closed until it's ready. The full guidebook on how pull requests are reviewed is here: [Code Review Guidelines](https://github.com/stan-dev/math/wiki/Developer-Doc#code-review-guidelines).
Start by filling in the Summary, Tests, and Side Effects sections of this pull request and then work through the handy checklist at the bottom. If anything significant is missing, the pull request may be closed until it's ready. The full guidebook on how pull requests are reviewed is here: [Code Review Guidelines](https://github.com/stan-dev/stan/wiki/Developer-process-overview#code-review-guidelines).

## Summary

Expand Down Expand Up @@ -40,7 +40,7 @@ Replace this text with a short note on what will change if this pull request is
- header checks pass, (`make test-headers`)
- dependencies checks pass, (`make test-math-dependencies`)
- docs build, (`make doxygen`)
- code passes the built in [C++ standards](https://github.com/stan-dev/stan/wiki/Code-Quality) checks (`make cpplint`)
- code passes the built in [C++ standards](https://github.com/stan-dev/stan/wiki/Coding-Style-and-Idioms) checks (`make cpplint`)

- [ ] the code is written in idiomatic C++ and changes are documented in the doxygen

Expand Down
6 changes: 6 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
37 changes: 13 additions & 24 deletions .github/workflows/header_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,23 @@ on:
- 'README.md'
- 'RELEASE-NOTES.txt'

permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
windows:
name: Windows
runs-on: windows-latest

steps:
- uses: n1hility/cancel-previous-runs@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
workflow: c-cpp.yml
if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/develop'"

- uses: actions/checkout@v2
- uses: actions/setup-python@v2
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: '2.x'
python-version: '3.x'

- name: Print g++/mingw32-make version and path
run: |
Expand All @@ -40,7 +41,7 @@ jobs:

- name: Build Math libs
shell: powershell
run: mingw32-make -f make/standalone math-libs
run: mingw32-make -f make/standalone math-libs -j2

- name: Run header tests
shell: powershell
Expand All @@ -51,13 +52,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: n1hility/cancel-previous-runs@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
workflow: c-cpp.yml
if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/develop'"

- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Run header tests
run: |
Expand All @@ -68,13 +63,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: n1hility/cancel-previous-runs@v2
with:
token: ${{ secrets.GITHUB_TOKEN }}
workflow: c-cpp.yml
if: "!startsWith(github.ref, 'refs/tags/') && github.ref != 'refs/heads/master' && github.ref != 'refs/heads/develop'"

- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Run header tests
run: |
Expand Down
Loading
Loading