Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event dispatcher in View and WebView optional #250

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 15, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Mar 15, 2024

PR Summary

  • Update to CHANGELOG
    A new entry has been added to the document that tracks the changes made across different versions of the software.

  • Changes in View.php
    This update allows the system used for managing events to be optional. It includes modifications to ensure that the system functions smoothly even when this component is not provided.

  • Adjustments in ViewTrait.php
    The system is now more lenient when the event manager isn't available, with new safeguards to prevent it from trying to manage events in such cases.

  • Updates to WebView.php
    Like with View.php, the event manager here is also optional. The same precautions have been implemented to prevent the system from managing events when it's not available.

  • Modifications in TestHelper.php
    There's no longer a need to import an additional component for managing events. The changes also allow the event manager to be provided as-is during testing, without requiring an instance of the once imported component.

@vjik vjik requested a review from a team March 15, 2024 10:34
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.26%. Comparing base (6ab2c25) to head (63e16eb).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #250      +/-   ##
============================================
- Coverage     99.75%   99.26%   -0.50%     
- Complexity      305      307       +2     
============================================
  Files            19       19              
  Lines           807      811       +4     
============================================
  Hits            805      805              
- Misses            2        6       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik added the status:code review The pull request needs review. label Mar 15, 2024
@vjik vjik merged commit 57372ba into master Mar 15, 2024
24 of 27 checks passed
@vjik vjik deleted the optional-event-dispatcher branch March 15, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants