-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #183: Move URI prefix to RouteCollection
#192
base: master
Are you sure you want to change the base?
Conversation
rustamwin
commented
Feb 25, 2023
Q | A |
---|---|
Is bugfix? | ✔️/❌ |
New feature? | ✔️/❌ |
Breaks BC? | ✔️/❌ |
Fixed issues | comma-separated list of tickets # fixed by the PR, if any |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #192 +/- ##
============================================
+ Coverage 97.61% 97.64% +0.02%
- Complexity 140 142 +2
============================================
Files 9 9
Lines 419 424 +5
============================================
+ Hits 409 414 +5
Misses 10 10
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a major release since it breaks BC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UrlGeneratorInterface
not depend from RouteCollection
and may used:
- without
RouteCollection
, - with one
RouteCollection
, - with several
RouteCollection
.
We must keep URI prefix in UrlGeneratorInterface
.