Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #183: Move URI prefix to RouteCollection #192

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (805f0d8) 97.61% compared to head (dda40ba) 97.64%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #192      +/-   ##
============================================
+ Coverage     97.61%   97.64%   +0.02%     
- Complexity      140      142       +2     
============================================
  Files             9        9              
  Lines           419      424       +5     
============================================
+ Hits            409      414       +5     
  Misses           10       10              
Impacted Files Coverage Δ
src/RouteCollection.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a major release since it breaks BC.

Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UrlGeneratorInterface not depend from RouteCollection and may used:

  1. without RouteCollection,
  2. with one RouteCollection,
  3. with several RouteCollection.

We must keep URI prefix in UrlGeneratorInterface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants