Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error code & show function arguments #125

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add error code & show function arguments #125

wants to merge 12 commits into from

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Jul 18, 2024

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC?
image
  • Error code showed
  • Showed functions arguments if they are

@xepozz xepozz requested a review from a team July 18, 2024 09:33
@xepozz xepozz added the status:code review The pull request needs review. label Jul 18, 2024
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome 👍 Please add a line to CHANGELOG and merge.

@@ -135,7 +135,8 @@ public function register(): void
return true;
}

$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
$backtrace = debug_backtrace();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$backtrace = debug_backtrace();
$backtrace = debug_backtrace(0);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omits unused index "object" and populates index "args". See https://www.php.net/manual/en/function.debug-backtrace.php

src/Renderer/HtmlRenderer.php Show resolved Hide resolved
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add line to changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants