Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve tests #229

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Fix and improve tests #229

merged 2 commits into from
Nov 7, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Nov 4, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

what-the-diff bot commented Nov 4, 2023

PR Summary

  • Refined migration tests
    The outdated instruction in AbstractMigratorTest.php, that ran a now-unnecessary downward migration, has been removed for the sake of efficiency.

  • Clearing additional tables in MSSQL and MySQL
    In both the MssqlFactory.php and MysqlFactory.php files, 'person', 'book', and 'chapter' tables have been added to the clearDatabase method. This means when the clear database function is used, data in these tables will be erased leading to a fresher start point for new data entries.

  • Adding 'PERSON' table clearance for Oracle
    In a similar fashion, the OracleFactory.php file now includes the 'PERSON' table in the clearDatabase method. This adjustment ensures parity of the clear database operation across various database systems.

  • Enhancements to SQLite database clearance
    Code changes made to SqLiteFactory.php now store the result of the createCommand function in a variable, which is then used to drop tables in the clearDatabase method. This enhancement promotes code reusability, which often leads to more efficient and easier-to-maintain software.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ef6724) 99.79% compared to head (43ec793) 99.79%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #229   +/-   ##
=========================================
  Coverage     99.79%   99.79%           
  Complexity      290      290           
=========================================
  Files            19       19           
  Lines           960      960           
=========================================
  Hits            958      958           
  Misses            2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review November 4, 2023 04:34
@Tigrov Tigrov requested a review from a team November 7, 2023 10:39
@Tigrov Tigrov added the status:code review The pull request needs review. label Nov 7, 2023
@Tigrov Tigrov merged commit 5ae8c9d into master Nov 7, 2023
78 checks passed
@Tigrov Tigrov deleted the fix-improve-tests branch November 7, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants