feat: add missing readonly modifier

yifanwww · Sep 1, 2023 · 9986570 · 9986570
1 parent 4e494f4
commit 9986570
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/packages/app-main/src/main/appInfo.ts b/packages/app-main/src/main/appInfo.ts
@@ -4,11 +4,11 @@ import path from 'node:path';
 export class AppInfo {
     private static _instance?: AppInfo;
 
-    private _appPath: string;
-    private _srcPath: string;
-    private _userDataPath: string;
+    private readonly _appPath: string;
+    private readonly _srcPath: string;
+    private readonly _userDataPath: string;
 
-    private _startedTime: number;
+    private readonly _startedTime: number;
 
     private constructor() {
         const isInASAR = __dirname.includes('.asar');

diff --git a/packages/app-main/src/main/configuration/window.ts b/packages/app-main/src/main/configuration/window.ts
@@ -58,16 +58,16 @@ interface IWindowStateKeeperOptions {
 }
 
 export class WindowStateKeeper {
-    private _type: WindowType;
+    private readonly _type: WindowType;
 
-    private _state: IWindowState;
+    private readonly _state: IWindowState;
     private _stateChangeTimer: Nullable<NodeJS.Timer>;
     private _windowRef: Nullable<BrowserWindow>;
 
-    private _defaultWidth: number;
-    private _defaultHeight: number;
-    private _defaultMaximized: boolean;
-    private _defaultFullScreen: boolean;
+    private readonly _defaultWidth: number;
+    private readonly _defaultHeight: number;
+    private readonly _defaultMaximized: boolean;
+    private readonly _defaultFullScreen: boolean;
 
     constructor(type: WindowType, options?: IWindowStateKeeperOptions) {
         this._type = type;

diff --git a/packages/app-main/src/main/window/windowManager.ts b/packages/app-main/src/main/window/windowManager.ts
@@ -19,7 +19,7 @@ export class WindowManager {
         return WindowManager._instance;
     }
 
-    private _store: WindowStore;
+    private readonly _store: WindowStore;
 
     private constructor() {
         this._store = {};

diff --git a/packages/scripts/src/webpack/utils/reloadElectronWebpackPlugin.ts b/packages/scripts/src/webpack/utils/reloadElectronWebpackPlugin.ts
@@ -6,8 +6,8 @@ import type { Compiler } from 'webpack';
 const electron = _electron as unknown as string;
 
 export class ReloadElectronWebpackPlugin {
-    private _cwd: string;
-    private _projectDir: string;
+    private readonly _cwd: string;
+    private readonly _projectDir: string;
     private _process: child.ChildProcess | null;
 
     constructor(projectDir: string, cwd: string) {