Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Data.Word8 when possible #966

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Dec 29, 2023

Wanted to get rid of literal numbers when we can use values from Data.Word8 and have it more obvious what's happening in the code. Also feels more robust to see _colon instead of 58 or 0x3A.

@Vlix
Copy link
Contributor Author

Vlix commented Dec 29, 2023

The new Stackage Nightly seems to be missing a lot of stuff.
Then there's quic and websockets that need to accept bytestring < 0.13, I think.

@kazu-yamamoto do you think you'll be able to add http2, http3, quic, websockets, etc. to the (nightly) stackage in the foreseeable future?

@Vlix Vlix force-pushed the use-Data-Word8-when-possible branch from 5be9e1a to dc9119c Compare December 29, 2023 03:01
@kazu-yamamoto kazu-yamamoto self-requested a review December 29, 2023 12:55
@kazu-yamamoto
Copy link
Contributor

I did it for http2 but I should do for more libraries as you pointed out.
I should find time maybe tomorrow.
The end of year and the beginning of the new year is a vacation period in Japan.
So, please don't expect quick response.
I will work again from 9th January.

@Vlix
Copy link
Contributor Author

Vlix commented Dec 29, 2023

I don't expect anything really, just wondered if you were planning to work on it :)

You have a nice New Year's 👋 take it easy!

Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 142c679 into yesodweb:master Jan 9, 2024
18 checks passed
@kazu-yamamoto
Copy link
Contributor

I have released a new version of quic which allows bytestring 0.12.
http3 does not have the upper boundary.
I don't maintain websockets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants