Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiny refactor: adjust placement of shared "I.writeIORef ref count'" #957

Merged
merged 2 commits into from
Dec 12, 2023
Merged

tiny refactor: adjust placement of shared "I.writeIORef ref count'" #957

merged 2 commits into from
Dec 12, 2023

Conversation

mitchellwrosen
Copy link
Contributor

This PR just moves the placement of a writeIORef that takes place in both branches of a conditional just below.

@kazu-yamamoto kazu-yamamoto self-requested a review December 12, 2023 00:20
@kazu-yamamoto
Copy link
Contributor

May I ask two things?

  1. Rebase this on master
  2. Replace case with if

@kazu-yamamoto
Copy link
Contributor

If you replace this onto master, CI should pass.

@mitchellwrosen
Copy link
Contributor Author

@kazu-yamamoto Sure, done

kazu-yamamoto
kazu-yamamoto approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 8345744 into yesodweb:master Dec 12, 2023
@kazu-yamamoto
Copy link
Contributor

Merged.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazu-yamamoto kazu-yamamoto kazu-yamamoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitchellwrosen @kazu-yamamoto