Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wai: forgot to change @since declaration #954

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Dec 9, 2023

Was checking wai one last time before releasing v3.2.4.
Found this documentation error that was missed, so fixed it here.

Shall we release wai-3.2.4 once this is merged?

Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazu-yamamoto kazu-yamamoto merged commit 2eb5339 into yesodweb:master Dec 10, 2023
3 of 15 checks passed
@kazu-yamamoto
Copy link
Contributor

@Vlix Merged.
Releasing a new version of wai is a good idea but I don't have permission to upload it.

@Vlix
Copy link
Contributor Author

Vlix commented Dec 10, 2023

@kazu-yamamoto Are you sure? You're listed as a Maintainer on hackage/wai
Do you want to give it a try? Just to make sure if it works or not? If it doesn't work, I can try as well.

@Vlix Vlix deleted the prep-for-3.2.4-release branch December 10, 2023 01:45
@kazu-yamamoto
Copy link
Contributor

Ohhhhps.
How did I misunderstand this?
I've uploaded wai v3.2.4.

@Vlix
Copy link
Contributor Author

Vlix commented Dec 10, 2023

Hey, no worries 👍 Thanks for the upload 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants