-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No using data-default #1011
No using data-default #1011
Conversation
ad208f1
to
4abdd80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this change.
Since this PR includes CI stuff, @Vlix should merge this PR by himself, I think.
a73fee9
to
ac5cf08
Compare
Released new minor version for |
I have released @Vlix You should push the tag for |
@kazu-yamamoto I did do that, didn't I? Or do you mean the 3.1.16 tag? (seems I forgot that one) EDIT: also pushed that one |
Before submitting your PR, check that you've:
@since
declarations to the HaddockAfter submitting your PR:
So I really want to get rid of any
data-default
, and now withtls-2.1.3
we can at least get rid of the dependency onwarp-tls
. Though it requirestls >= 2.1.3
, which will be a bit more restrictive, though I don't think many people will have problems because of this.I've also tried my best to obviously deprecate the
Default
instances that are still in this repo. I've made a synonym fordefaultGzipSettings
, sincedef
was also directly (re-)exported, so now we can give an actual Deprecation warning. Though we can't on the other instances... unfortunately.I'm hoping come
wai-extra-3.3
these instances can be removed as well.