Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No using data-default #1011

Merged
merged 5 commits into from
Nov 6, 2024
Merged

No using data-default #1011

merged 5 commits into from
Nov 6, 2024

Conversation

Vlix
Copy link
Contributor

@Vlix Vlix commented Nov 3, 2024

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

So I really want to get rid of any data-default, and now with tls-2.1.3 we can at least get rid of the dependency on warp-tls. Though it requires tls >= 2.1.3, which will be a bit more restrictive, though I don't think many people will have problems because of this.

I've also tried my best to obviously deprecate the Default instances that are still in this repo. I've made a synonym for defaultGzipSettings, since def was also directly (re-)exported, so now we can give an actual Deprecation warning. Though we can't on the other instances... unfortunately.

I'm hoping come wai-extra-3.3 these instances can be removed as well.

@Vlix Vlix force-pushed the no-using-data-default-plz branch from ad208f1 to 4abdd80 Compare November 3, 2024 13:37
@Vlix Vlix requested a review from kazu-yamamoto November 3, 2024 13:38
@Vlix Vlix mentioned this pull request Nov 5, 2024
3 tasks
Copy link
Contributor

@kazu-yamamoto kazu-yamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change.
Since this PR includes CI stuff, @Vlix should merge this PR by himself, I think.

@Vlix Vlix force-pushed the no-using-data-default-plz branch from a73fee9 to ac5cf08 Compare November 6, 2024 04:09
@Vlix Vlix merged commit 2393f89 into yesodweb:master Nov 6, 2024
14 checks passed
@Vlix Vlix deleted the no-using-data-default-plz branch November 6, 2024 04:47
@Vlix
Copy link
Contributor Author

Vlix commented Nov 6, 2024

Released new minor version for wai-extra, but aren't a maintainer for warp-tls. @kazu-yamamoto could you upload warp-tls-3.4.10?

@kazu-yamamoto
Copy link
Contributor

I have released warp-tls-3.4.10.

@Vlix You should push the tag for wai-extra to github.

@Vlix
Copy link
Contributor Author

Vlix commented Nov 6, 2024

@kazu-yamamoto I did do that, didn't I?

Or do you mean the 3.1.16 tag? (seems I forgot that one)

EDIT: also pushed that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants