-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for -XTypeApplications
#279
Conversation
The earliest GHC version this could support is 8.2.1 (2017), according to the metadata for the commit introducing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Can you add a minor version bump and a ChangeLog comment about the addition?
No, it's fine to support only GHC 8.2 and up. |
I've bumped the version number and edited the changelog. Thanks! |
Is this ready for merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good, thanks!
I'm seeing a test failure on this PR:
I think we need to mark this release as broken on Hackage, and possibly do a revert of this PR until it can be fixed. Thoughts @snoyberg @mixphix ? |
This commit solves the failing test. |
I'll do both of those @parsonsmatt. |
Augments the Shakespeare base parser to support parsing type applications, e.g.
#{show @Integer 4}
, to improve working with polymorphism within quasi-quotes. Will parse type constructors, symbol types, type-level naturals, and single-depth compositions thereof, but will not parse things like@(Const (Maybe a) b)
with nested parentheses.