Add the ability to specify body hash method #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the failing tests are the same as on master. Is there interest in this or any feedback around it? Happy to update if there are desired changes. |
parsonsmatt
approved these changes
Aug 31, 2022
There was a problem hiding this comment.
This looks good to me!
@snoyberg anything I can do to help get this merged and released?
| @@ -103,6 +103,8 @@ data OAuth = OAuth { oauthServerName :: String -- ^ Service name (default: | |||
| -- ^ Optional authorization realm (default: @Nothing@) | |||
| , oauthVersion :: OAuthVersion | |||
| -- ^ OAuth spec version (default: 'OAuth10a') | |||
| , oauthBodyHashMethod :: BodyHashMethod | |||
There was a problem hiding this comment.
Since the constructor isn't exposed, this is a feature addition - so a minor version bump
I'm not really the maintainer of authenticate-oauth (though I've done some of the work on it recently), and I'm not sure if the maintainers are still following this repo. I'd be happy to add you both here and on Hackage if you'd like to jump in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some APIs require the body hash method follow the signature hash method. While the spec alludes to the body hash method following the signature method, doing so would break library users expecting the current behavior of a SHA-1 body hash no matter what signature method is specified. An additional configuration parameter is added for the body hash method with a default of SHA-1 so users can update without changes and maintain current behavior.