Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary repository. #4229

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

fatihaktas845
Copy link
Contributor

@fatihaktas845 fatihaktas845 commented Apr 22, 2024

The given repository is no longer needed to install the specified packages.

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

[Please explain in detail why the changes in this PR are needed.]


This change is Reviewable

The given repository is no longer needed to install the specified packages.
Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.

The PPA was added to instructions at the point where tsserver started requiring nodejs that was newer than what existed in Ubuntu at the time.
As a general policy, the instructions should work out-of-the-box for the latest Ubuntu LTS.

I think we should wait for ubuntu 24.04 to be released this week and then start with some more general cleanup.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @fatihaktas845)

@fatihaktas845
Copy link
Contributor Author

But the packages you mentioned are now available in Ubuntu's own repositories. Why would they remove them in a newer Ubuntu version? If they were going to remove it in a newer version, then why did they add it now?

Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked and the new ubuntu does have a new enough nodejs. We can safely merge this.

Reviewable status: 0 of 2 LGTMs obtained (waiting on @fatihaktas845)

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @fatihaktas845)

@bstaletic bstaletic added the Ship It! Manual override to merge a PR by maintainer label Aug 16, 2024
Copy link
Contributor Author

@fatihaktas845 fatihaktas845 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @fatihaktas845)

@bstaletic
Copy link
Collaborator

This was run a while ago, so mergify config does not match.
Merging manually.

@bstaletic bstaletic merged commit 4ca5b45 into ycm-core:master Aug 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants