-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unnecessary repository. #4229
Conversation
The given repository is no longer needed to install the specified packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request.
The PPA was added to instructions at the point where tsserver started requiring nodejs that was newer than what existed in Ubuntu at the time.
As a general policy, the instructions should work out-of-the-box for the latest Ubuntu LTS.
I think we should wait for ubuntu 24.04 to be released this week and then start with some more general cleanup.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @fatihaktas845)
But the packages you mentioned are now available in Ubuntu's own repositories. Why would they remove them in a newer Ubuntu version? If they were going to remove it in a newer version, then why did they add it now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked and the new ubuntu does have a new enough nodejs. We can safely merge this.
Reviewable status: 0 of 2 LGTMs obtained (waiting on @fatihaktas845)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @fatihaktas845)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @fatihaktas845)
This was run a while ago, so mergify config does not match. |
The given repository is no longer needed to install the specified packages.
PR Prelude
Thank you for working on YCM! :)
Please complete these steps and check these boxes (by putting an
x
insidethe brackets) before filing your PR:
rationale for why I haven't.
actually perform all of these steps.
Why this change is necessary and useful
[Please explain in detail why the changes in this PR are needed.]
This change is