Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Fix tests after ycmd update #4222

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Feb 18, 2024

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

The ycmd update that was pushed a moment ago has broken a single vim level test - JDT once again reordered some fixits.


This change is Reviewable

@bstaletic bstaletic changed the title Fix tests after ycmd update [READY] Fix tests after ycmd update Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Merging #4222 (ce0900f) into master (b6a327e) will increase coverage by 11.32%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4222       +/-   ##
===========================================
+ Coverage   78.26%   89.58%   +11.32%     
===========================================
  Files          29       34        +5     
  Lines        2760     4445     +1685     
===========================================
+ Hits         2160     3982     +1822     
+ Misses        600      463      -137     

Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

@bstaletic bstaletic added the Ship It! Manual override to merge a PR by maintainer label Feb 18, 2024
Copy link
Contributor

mergify bot commented Feb 18, 2024

Thanks for sending a PR!

@mergify mergify bot merged commit c3c0332 into ycm-core:master Feb 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants