Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a few typos in comments #4220

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Correct a few typos in comments #4220

merged 1 commit into from
Feb 5, 2024

Conversation

JJCUBER
Copy link
Contributor

@JJCUBER JJCUBER commented Feb 4, 2024

PR Prelude

Thank you for working on YCM! :)

Please complete these steps and check these boxes (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood YCM's CONTRIBUTING document.
  • I have read and understood YCM's CODE_OF_CONDUCT document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

While this is quite a minor change, I feel that it helps with the readability and flow of the source code for people first familiarizing themselves with it (and/or people coming back to it after a while).

I did not include tests since only comments were modified.


This change is Reviewable

This was only for autoload/youcompleteme.vim
Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Cheers.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @JJCUBER)

@bstaletic
Copy link
Collaborator

bstaletic commented Feb 5, 2024

:lgtm:

Thanks!

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Merging #4220 (a73fbdf) into master (0497bb0) will decrease coverage by 0.30%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4220      +/-   ##
==========================================
- Coverage   89.74%   89.44%   -0.30%     
==========================================
  Files          34       34              
  Lines        4425     4425              
==========================================
- Hits         3971     3958      -13     
- Misses        454      467      +13     

Copy link
Collaborator

@bstaletic bstaletic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 2 LGTMs obtained (waiting on @JJCUBER)

Copy link
Contributor

mergify bot commented Feb 5, 2024

Thanks for sending a PR!

@mergify mergify bot merged commit 1212def into ycm-core:master Feb 5, 2024
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants