✨ Feature: support app jwt auth using client id (#129)

githubkit/auth/app.py

@@ -29,7 +29,7 @@ class AppAuth(httpx.Auth):
     """GitHub App or Installation Authentication Hook"""
 
     github: "GitHubCore"
-    app_id: Union[str, int]
+    app_id: Union[str, int, None]
     private_key: str
     client_id: Optional[str] = None
     client_secret: Optional[str] = None
@@ -39,12 +39,22 @@ class AppAuth(httpx.Auth):
     permissions: Union[Unset, "AppPermissionsType"] = UNSET
     cache: "BaseCache" = DEFAULT_CACHE
 
-    JWT_CACHE_KEY = "githubkit:auth:app:{app_id}:jwt"
+    JWT_CACHE_KEY = "githubkit:auth:app:{issuer}:jwt"
     INSTALLATION_CACHE_KEY = (
-        "githubkit:auth:app:{app_id}:installation:"
+        "githubkit:auth:app:{issuer}:installation:"
         "{installation_id}:{permissions}:{repositories}:{repository_ids}"
     )
 
+    @property
+    def issuer(self) -> str:
+        # issuer can be either app_id or client_id
+        issuer = self.client_id if self.app_id is None else self.app_id
+        if issuer is None:
+            raise AuthCredentialError(
+                "Either app_id or client_id must be provided for GitHub APP"
+            )
+        return str(issuer)
+
     def _get_api_route(self, url: httpx.URL) -> httpx.URL:
         """Get the api route (path only) for the given url."""
         base_url_path = self.github.config.base_url.path
@@ -65,16 +75,17 @@ def _create_jwt(self) -> str:
                 "JWT support for GitHub APP should be installed "
                 "with `pip install githubkit[auth-app]`"
             )
+
         time = datetime.now(timezone.utc) - timedelta(minutes=1)
         expire_time = time + timedelta(minutes=10)
         return jwt.encode(
-            {"iss": str(self.app_id), "iat": time, "exp": expire_time},
+            {"iss": self.issuer, "iat": time, "exp": expire_time},
             self.private_key,
             algorithm="RS256",
         )
 
     def _get_jwt_cache_key(self) -> str:
-        return self.JWT_CACHE_KEY.format(app_id=self.app_id)
+        return self.JWT_CACHE_KEY.format(issuer=self.issuer)
 
     def get_jwt(self) -> str:
         cache_key = self._get_jwt_cache_key()
@@ -159,7 +170,7 @@ def _get_installation_cache_key(self) -> str:
             [] if isinstance(self.repository_ids, Unset) else self.repository_ids
         )
         return self.INSTALLATION_CACHE_KEY.format(
-            app_id=self.app_id,
+            issuer=self.issuer,
             installation_id=self.installation_id,
             permissions=",".join(
                 name if value == "read" else f"{name}!"
@@ -247,12 +258,19 @@ async def async_auth_flow(
 class AppAuthStrategy(BaseAuthStrategy):
     """GitHub App Authentication"""
 
-    app_id: Union[str, int]
+    app_id: Union[str, int, None]
     private_key: str
     client_id: Optional[str] = None
     client_secret: Optional[str] = None
     cache: "BaseCache" = DEFAULT_CACHE
 
+    def __post_init__(self):
+        # either app_id or client_id must be provided
+        if self.app_id is None and self.client_id is None:
+            raise AuthCredentialError(
+                "Either app_id or client_id must be provided for GitHub APP"
+            )
+
     def as_installation(
         self,
         installation_id: int,
@@ -294,7 +312,7 @@ def get_auth_flow(self, github: "GitHubCore") -> httpx.Auth:
 class AppInstallationAuthStrategy(BaseAuthStrategy):
     """GitHub App Installation Authentication"""
 
-    app_id: Union[str, int]
+    app_id: Union[str, int, None]
     private_key: str
     installation_id: int
     client_id: Optional[str] = None
@@ -304,6 +322,13 @@ class AppInstallationAuthStrategy(BaseAuthStrategy):
     permissions: Union[Unset, "AppPermissionsType"] = UNSET
     cache: "BaseCache" = DEFAULT_CACHE
 
+    def __post_init__(self):
+        # either app_id or client_id must be provided
+        if self.app_id is None and self.client_id is None:
+            raise AuthCredentialError(
+                "Either app_id or client_id must be provided for GitHub APP"
+            )
+
     def as_app(self) -> AppAuthStrategy:
         return AppAuthStrategy(
             self.app_id,