Serialize URL string contents to prevent XSS #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redonkulus
approved these changes
Jan 9, 2024
|
New version with the fix published https://github.com/yahoo/serialize-javascript/releases/tag/v6.0.2. Thanks again! |
|
Hi there @redonkulus, I work in Red Hat Product Security and this came across my desk. As it looks CVE worthy, I was wondering if there was ever a CVE assigned for this issue? If not, we (Red Hat) can assist in that process if needed. |
|
@redonkulus : Can you please reach out to Github for CVE assignment like you did for CVE-2019-16769 for the same issue . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Fixes #172 by implementing @redonkulus's excellent suggestion. Additionally updates the tests to expect the newly encoded URL values, and adds a new test to ensure the serialized output does not contain any unsafe characters.
Thanks again to @redonkulus for finding and suggesting the fix!