ENH: Preparations for releasing v1.3.0 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
were writing in text-mode in PY3. and failing as encoding error.
Tokens work as usual while solving the DAG but they are never assigned any values to/from the operation's functions. + TC included. + Docs updated.\+ Added `modifiers` superclass to facilitate identification code. + refactored FunctionalOperation._compute().
+ _norm_kwargs:
+ use isinstance() instead of type-equality checks,
to support new modier classes;
+ avoid excessive dict searches with local vars.
not really needed, better be explicit which modifier is searched.
receiving partial inputs, needed for other operations.
+ The x2 TCs added just before are now passing.
NOTE dict are not deterministic in <PY3.6. So this commit would not improve determinism in those pythons. + build: add `boltons` dependency for ndexedSet. + doc: mark all set usage if affect determinism. + e.g. see reproducibility problem in yahoo#14.
the later described in yahoo#21.
not after compose(). + All TCs pass ok. + NOTE this is not yet what is described in yahoo#21.
to pass +TC checking DeleteInst vary when inputs change. - x4 TCs still failing, and need revamp of dag-solution.
+ Read the next doc-only commit to understand changes.
+ Renamed:
+ net.steps --> net.execution_plan.
+ (old)compile() --> _build_execution_plan()
+ _find_necessary_steps() --> (new)compile() + _solve_dag()
compile() became the master function invoking _solve_dag &
_build-execution_plan(), and do the caching.
+ refact(compute()): extract common tasks from sequential/parallel.
+ refact show_layers() to allow full-print, geting also string
(not just printing), and using custom classes for representation.
+ Raise AssertionError when invalid class in plan.
it's a logic error, not a language type-error.
Probaly unreported bug in v1.2.4 for '_neccessary_steps_cache`.
+ Pruning behaves correctly also when outputs given; this happens by breaking incoming provide-links to any given intermedediate inputs. + Unsatisfied detection now includes those without outputs due to broken links (above). + Remove some uneeded "glue" from unsatisfied-detection code, leftover from previous compile() refactoring. + Renamed satisfiable --> satisfied. + Improved unknown output requested raise-message. + x3 TCs PASS, x1 in yahoo#24 and the first x2 in yahoo#25. - 1x TCs in yahoo#25 still FAIL, and need "Pinning" of given-inputs (the operation MUST and MUST NOT run in these cases).
numpy was used just for its assert_raise
|
PR huyng#1 Done. |
|
Dear Huy, If you the original GH-repo is salvagable, i suggest the do any discussion eithetr on that repo, or on the commits themselves, so as not to proliferate information to multiple repos. |
so as to politely print IndexedSets in those attributes.
but still annotate edges with optional edge data-attribute. Reverted bc Operation must not know its network, to belong to more than one. Also the `Operation.net` contradicted `NetwotkOperation.net`; the later indeed is the network it wraps (not the net it is part of).
+ homegine titles + fix: autodoc renders nothing without :special-members:
ankostis
force-pushed
the
release-v1.3
branch
from
7f2976f
to
88c68e9
Compare
+ enh(net): mark dag-edges with sideffects; + enh(plot): plot sideffect inks as such; + enh(plot): update legend; + doc(plot): move legend text along with the code producing it. + doc: stray image fixes.
+ fix glitches in README.
if built without cleaing, stray artifacts might make it into wheel.
and when giving `pytest --lf` i get:
_____________________________________ ERROR collecting setup.py _____________________________________
/usr/lib/python3.7/distutils/fancy_getopt.py:233: in getopt
opts, args = getopt.getopt(args, short_opts, self.long_opts)
/usr/lib/python3.7/getopt.py:93: in getopt
opts, args = do_longs(opts, args[0][2:], longopts, args[1:])
/usr/lib/python3.7/getopt.py:157: in do_longs
has_arg, opt = long_has_args(opt, longopts)
/usr/lib/python3.7/getopt.py:174: in long_has_args
raise GetoptError(_('option --%s not recognized') % opt, opt)
E getopt.GetoptError: option --lf not recognized
as debug aid (was doing that for plans already). + enh: annotate also networks.
ankostis
force-pushed
the
release-v1.3
branch
from
863c7eb
to
7bd3f85
Compare
3 tasks
|
This is considered done. Review moved to #31. Will close with 1.3.0 |
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparations for baking a new release & last-days fixes.
in v1.2.4.
operation.__repr__()was crashing when not all arguments had been set - a condition frequtnly met during debugging session.inspired by @syamajala's 309338340.
CHANGES.rstchangelog, with flowcharts comparing versions 1.2.4 <-->1.3..0.sphinx_rtd_themeis the default for sphinx now.I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.