-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: refactor Network and DAG SOLVER to fix bad pruning #26
base: master
Are you sure you want to change the base?
Commits on Sep 28, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 617e577 - Browse repository at this point
Copy the full SHA 617e577View commit details
Commits on Sep 29, 2019
-
FIX(yahoo#13): BUG in plot-diagram writtin from PY2 era,
were writing in text-mode in PY3. and failing as encoding error.
Configuration menu - View commit details
-
Copy full SHA for f58d148 - Browse repository at this point
Copy the full SHA f58d148View commit details
Commits on Oct 1, 2019
-
enh(test): + x2 TC breaking UNSATISFIED operations...
receiving partial inputs, needed for other operations.
Configuration menu - View commit details
-
Copy full SHA for 52c0d77 - Browse repository at this point
Copy the full SHA 52c0d77View commit details -
ENH(net,yahoo#18): ignore UN-SATISFIABLE operations with partial inputs
+ The x2 TCs added just before are now passing.
Configuration menu - View commit details
-
Copy full SHA for bc4c221 - Browse repository at this point
Copy the full SHA bc4c221View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8daa07 - Browse repository at this point
Copy the full SHA b8daa07View commit details -
ENH(core): ORDERED SETs for DETERMINISTIC results
NOTE dict are not deterministic in <PY3.6. So this commit would not improve determinism in those pythons. + build: add `boltons` dependency for ndexedSet. + doc: mark all set usage if affect determinism. + e.g. see reproducibility problem in yahoo#14.
Configuration menu - View commit details
-
Copy full SHA for 12bdfe4 - Browse repository at this point
Copy the full SHA 12bdfe4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8377ca - Browse repository at this point
Copy the full SHA b8377caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 489b32c - Browse repository at this point
Copy the full SHA 489b32cView commit details
Commits on Oct 2, 2019
-
Configuration menu - View commit details
-
Copy full SHA for b102d44 - Browse repository at this point
Copy the full SHA b102d44View commit details -
Configuration menu - View commit details
-
Copy full SHA for de02885 - Browse repository at this point
Copy the full SHA de02885View commit details -
Configuration menu - View commit details
-
Copy full SHA for e1454fd - Browse repository at this point
Copy the full SHA e1454fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3736738 - Browse repository at this point
Copy the full SHA 3736738View commit details -
DOC(net): explain DAG solution & compilation...
the later described in yahoo#21.
Configuration menu - View commit details
-
Copy full SHA for c273068 - Browse repository at this point
Copy the full SHA c273068View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16d42f1 - Browse repository at this point
Copy the full SHA 16d42f1View commit details -
refact(dag): call compile() before compute.compute...
not after compose(). + All TCs pass ok. + NOTE this is not yet what is described in yahoo#21.
Configuration menu - View commit details
-
Copy full SHA for b92f103 - Browse repository at this point
Copy the full SHA b92f103View commit details
Commits on Oct 3, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6d1884e - Browse repository at this point
Copy the full SHA 6d1884eView commit details -
ENH(net): move compile() after SOLVE DAG ...
to pass +TC checking DeleteInst vary when inputs change. - x4 TCs still failing, and need revamp of dag-solution.
Configuration menu - View commit details
-
Copy full SHA for 619cae7 - Browse repository at this point
Copy the full SHA 619cae7View commit details -
REFACT(NET) COMPILE+COMPUTE...
+ Read the next doc-only commit to understand changes. + Renamed: + net.steps --> net.execution_plan. + (old)compile() --> _build_execution_plan() + _find_necessary_steps() --> (new)compile() + _solve_dag() compile() became the master function invoking _solve_dag & _build-execution_plan(), and do the caching. + refact(compute()): extract common tasks from sequential/parallel. + refact show_layers() to allow full-print, geting also string (not just printing), and using custom classes for representation. + Raise AssertionError when invalid class in plan. it's a logic error, not a language type-error.
Configuration menu - View commit details
-
Copy full SHA for eff351d - Browse repository at this point
Copy the full SHA eff351dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d959485 - Browse repository at this point
Copy the full SHA d959485View commit details -
FIX(net): new Ops invalidate execution-plan cache...
Probaly unreported bug in v1.2.4 for '_neccessary_steps_cache`.
Configuration menu - View commit details
-
Copy full SHA for 17eb2fd - Browse repository at this point
Copy the full SHA 17eb2fdView commit details -
+ Pruning behaves correctly also when outputs given; this happens by breaking incoming provide-links to any given intermedediate inputs. + Unsatisfied detection now includes those without outputs due to broken links (above). + Remove some uneeded "glue" from unsatisfied-detection code, leftover from previous compile() refactoring. + Renamed satisfiable --> satisfied. + Improved unknown output requested raise-message. + x3 TCs PASS, x1 in yahoo#24 and the first x2 in yahoo#25. - 1x TCs in yahoo#25 still FAIL, and need "Pinning" of given-inputs (the operation MUST and MUST NOT run in these cases).
Configuration menu - View commit details
-
Copy full SHA for 0830b7c - Browse repository at this point
Copy the full SHA 0830b7cView commit details
Commits on Oct 4, 2019
-
WIP/FIX(prune,yahoo#26): PIN intermediate inputs if operation before …
…must run - WIP: PARALLEL execution not adding PINS! + Insert "PinInstructions" in the execution-plan to avoid overwritting. + Add `_overwrite_collector` in `compose()` to collect re-calculated values. + FIX the last TC in yahoo#25.
Configuration menu - View commit details
-
Copy full SHA for 0dc1293 - Browse repository at this point
Copy the full SHA 0dc1293View commit details -
REFACT(net): part 3 of new dag-solver & pin refactoring
- STILL buggy PIN on PARALLEL, 2 DISABLED TCs FAIL: - test_pruning_with_given_intermediate_and_asked_out() - test_unsatisfied_operations_same_out() + move check if value in asked outputs before cache-evicting it in build-execution-plan time - compute methods don't need outputs anymore. + test: speed up parallel/multihtread TCs by reducing delays & repetitions. + refact: network rightfully adopted stray functions for parallel processing - they all worke on the net.graph, + upd: networkx api by indexing on `dag.nodes` views. + enh: add log message when deleting in parallel (in par with sequential code). + refact: var-renames, if-then-else simplifications, pythonisms. + doc: A lot!
Configuration menu - View commit details
-
Copy full SHA for 06f6554 - Browse repository at this point
Copy the full SHA 06f6554View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cc733e - Browse repository at this point
Copy the full SHA 1cc733eView commit details
Commits on Oct 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 5c3b8ef - Browse repository at this point
Copy the full SHA 5c3b8efView commit details -
WIP/FIX(PIN): PARALLEL DELs decide on PRUNED-dag (not full)...
- WIP: x4 TCs FAIL and still not discovered th bug :-( + BUT ALL+AUGMENTED PARALLEL TCs pass (yahoo#26 were failing some) + refact: net stores also `pruned_dag` (not only `steps`). + refact: _solve_dag() --> _prune_dag(). + doc: +a lot. + TODO: store pruned_dag in own ExePlan class.
Configuration menu - View commit details
-
Copy full SHA for 58977a4 - Browse repository at this point
Copy the full SHA 58977a4View commit details -
FIX(NET): were FORGETTING PRUNED ASKED-OUTPUTs...
... bugged in the opening commit d403783 of this PR, and discovered 68(!) commits later, and all that time had to live with x4 broken TCs with asked-outputs.
Configuration menu - View commit details
-
Copy full SHA for 27f222d - Browse repository at this point
Copy the full SHA 27f222dView commit details -
FIX(<PY3.5): ORDERED DiGRAPH for old Python to fix TCs
+ Partial fix deterministic results (yahoo#22-2.4.3i).
Configuration menu - View commit details
-
Copy full SHA for 7fe6080 - Browse repository at this point
Copy the full SHA 7fe6080View commit details -
FIX(DAG): broken_dag had PLAIN-STR instead of DataNode...
bc subgraph was taken on plain string outputs. + minor upd err-msg terminology.
Configuration menu - View commit details
-
Copy full SHA for 67aaadc - Browse repository at this point
Copy the full SHA 67aaadcView commit details
Commits on Oct 16, 2019
-
FIX(net): bad refactor had broken PARALLEL EVICTION ...
due to bad node check, evicting parallels it nevered kicked in.
Configuration menu - View commit details
-
Copy full SHA for fb1b074 - Browse repository at this point
Copy the full SHA fb1b074View commit details