FIX: use insertion-ordered sets for deterministic results #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE dict are not deterministic in <PY3.6. So this commit would not improve determinism in those pythons. + build: add `boltons` dependency for ndexedSet. + doc: mark all set usage if affect determinism. + e.g. see reproducibility problem in yahoo#14.
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
=======================================
+ Coverage 77.87% 78% +0.12%
=======================================
Files 5 5
Lines 348 350 +2
=======================================
+ Hits 271 273 +2
Misses 77 77
Continue to review full report at Codecov.
|
This was referenced Oct 3, 2019
ankostis
referenced
this pull request
in syamajala/graphkit
Oct 8, 2019
33 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23 +/- ##
=========================================
Coverage ? 78.00%
=========================================
Files ? 5
Lines ? 350
Branches ? 0
=========================================
Hits ? 273
Misses ? 77
Partials ? 0
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 1 issue from #22 (but not yet any TC to prove it!), see also reproducibility problem in #14.
NOTE: dicts are not deterministic in <PY3.6. So this commit would not improve determinism in those pythons.
boltonsdependency forIndexedSet.set()usage whether they would affect determinism.nx.dag.<method>package(remnant from older
networkxversions?)I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.