ENH: annotate graph edges as optionals #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usefull when 2 (or more) operations provifing the same output, and only one has fully satisfied inputs. Before it would fail trying to evaluate the un-satisfied ones. + New TC added. .
were writing in text-mode in PY3. and failing as encoding error.
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=========================================
+ Coverage 77.87% 78.3% +0.43%
=========================================
Files 5 5
Lines 348 355 +7
=========================================
+ Hits 271 278 +7
Misses 77 77
Continue to review full report at Codecov.
|
ankostis
changed the title
ankostis
changed the title
|
My mistake, this enhancement is not needed. Will scavenge TC. |
ankostis
added a commit
to ankostis/graphtik
that referenced
this pull request
Oct 5, 2019
+ enh TC with parallel. + Scavenged from yahoo#20.
21 tasks
ankostis
changed the title
|
Eventually merged. |
ankostis
added a commit
to ankostis/graphtik
that referenced
this pull request
Oct 11, 2019
but still annotate edges with optional edge data-attribute. Reverted bc Operation must not know its network, to belong to more than one. Also the `Operation.net` contradicted `NetwotkOperation.net`; the later indeed is the network it wraps (not the net it is part of).
ankostis
added a commit
to ankostis/graphtik
that referenced
this pull request
Oct 11, 2019
but still annotate edges with optional edge data-attribute. Reverted bc Operation must not know its network, to belong to more than one. Also the `Operation.net` contradicted `NetwotkOperation.net`; the later indeed is the network it wraps (not the net it is part of).
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optionalwith theneed <-- operationedge (instead of only on theneednode).I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.