Fix "yadm clone" from within a subdir of $YADM_WORK #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running "yadm clone" from a subdirectory of $YADM_WORK, e.g. from $HOME/Music, YADM failed to populate its working context: The list of files returned by the subsequent "git ls-files --deleted" was empty then.
|
I believe that this closing this pull request might also fix #345, since I was running into the same problem while also using fish. The underlying cause of the issue however most likely has nothing to do with fish at all - but not being in $HOME when doing yadm clone. Since the index is not properly reset, no files are copied during clone, and all files are marked as deleted afterwards - since they haven't been copied after all. |
|
running into this as well. Is there anything else needed before merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When running "yadm clone" from a subdirectory of $YADM_WORK, e.g. from
$HOME/Music, YADM failed to populate its working context: The list of
files returned by the subsequent "git ls-files --deleted" (within the yadm script)
was empty then.
Previous Behavior
When doing a "yadm clone" while the current working directory is a subdir
of $YADM_WORK, the working context in $YADM_WORK is not populated
with the files from the dotfile repository.
New Behavior
Everything works fine even when being in a subdirectory of $YADM_WORK.
Have [tests][1] been written for this change?
No, but all current tests passed.
Have these commits been [signed with GnuPG][2]?
No