Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI dependencies #5

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

misantron
Copy link
Contributor

@misantron misantron commented Oct 23, 2023

Update cobra and pflag:

  • Upgraded github.com/spf13/cobra from v0.0.5 to v1.7.0.
  • Not changing github.com/spf13/pflag as it is already up-to-date.
  • Updated gopkg.in/yaml.v2 from v2.2.8 to gopkg.in/yaml.v3 v3.0.1.
  • Corrected spelling and syntax errors.

This pull request primarily focuses on updating the library versions and does not introduce new tests.

Reference: #3

@yaacov
Copy link
Owner

yaacov commented Oct 24, 2023

Hello,

Thanks for the pull request! I noticed you updated both pflag and cobra to their latest versions. The syntax corrections you made are greatly appreciated.

Additionally, would you mind updating the pull request description to detail the new versions that have been updated in this PR? It would be helpful to have a note about the syntax fixes as well.

Lastly, please ensure that there are unit tests for the updated methods in SQLConfig and YAML.

@yaacov
Copy link
Owner

yaacov commented Oct 31, 2023

@misantron, thank you for this pull request 🔥
As this issue is tagged for hacktoberfest and Hacktoberfest concludes today, I'll merge this pull request to ensure its validity for the event. We can address the missing tests in a subsequent pull request.

@yaacov yaacov merged commit ec576c4 into yaacov:master Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants