Refactoring: renamed the debug and localization strings used in the I…

…nstallBinaryUpdate() private method of the FrmUpdate class.
xvitaly · Jan 24, 2025 · de24ea3 · de24ea3
1 parent bf5f1af
commit de24ea3
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 22 deletions.
diff --git a/src/mhed/AppStrings.Designer.cs b/src/mhed/AppStrings.Designer.cs
diff --git a/src/mhed/AppStrings.resx b/src/mhed/AppStrings.resx
@@ -273,7 +273,7 @@
   <data name="AF_Version" xml:space="preserve">
     <value>Version: {0}</value>
   </data>
-  <data name="UP_UpdateFailure" xml:space="preserve">
+  <data name="UP_StartUpdateInstallerFailure" xml:space="preserve">
     <value>An error occurred while trying to run the installer of the new version! The application has not been updated.</value>
   </data>
   <data name="UP_InstallUpdateError" xml:space="preserve">

diff --git a/src/mhed/AppStrings.ru.resx b/src/mhed/AppStrings.ru.resx
@@ -273,7 +273,7 @@
   <data name="AF_Version" xml:space="preserve">
     <value>Версия: {0}</value>
   </data>
-  <data name="UP_UpdateFailure" xml:space="preserve">
+  <data name="UP_StartUpdateInstallerFailure" xml:space="preserve">
     <value>Произошла ошибка при попытке запуска модуля установки новой версии! Программа не была обновлена.</value>
   </data>
   <data name="UP_InstallUpdateError" xml:space="preserve">

diff --git a/src/mhed/DebugStrings.Designer.cs b/src/mhed/DebugStrings.Designer.cs
diff --git a/src/mhed/DebugStrings.resx b/src/mhed/DebugStrings.resx
@@ -198,12 +198,12 @@
   <data name="AppDbgExUpDeleteFile" xml:space="preserve">
     <value>Exception when trying to delete the downloaded file with an incorrect hash.</value>
   </data>
-  <data name="AppDbgExUpInstallBinaryUpdate" xml:space="preserve">
-    <value>Exception while trying to run the installer of the new version.</value>
-  </data>
   <data name="AppDbgExUpInstallUpdate" xml:space="preserve">
     <value>Exception while trying to download and install the application update.</value>
   </data>
+  <data name="AppDbgExUpStartUpdateInstaller" xml:space="preserve">
+    <value>Exception while trying to run the installer of the new version.</value>
+  </data>
   <data name="AppDbgHostsFileDoesNotExists" xml:space="preserve">
     <value>Hosts file does not exists.</value>
   </data>

diff --git a/src/mhed/FrmUpdate.cs b/src/mhed/FrmUpdate.cs
@@ -172,8 +172,8 @@ private bool InstallBinaryUpdate()
                     }
                     catch (Exception Ex)
                     {
-                        Logger.Error(Ex, DebugStrings.AppDbgExUpInstallBinaryUpdate);
-                        MessageBox.Show(AppStrings.UP_UpdateFailure, Properties.Resources.AppName, MessageBoxButtons.OK, MessageBoxIcon.Error);
+                        Logger.Error(Ex, DebugStrings.AppDbgExUpStartUpdateInstaller);
+                        MessageBox.Show(AppStrings.UP_StartUpdateInstallerFailure, Properties.Resources.AppName, MessageBoxButtons.OK, MessageBoxIcon.Error);
                     }
                 }
                 else