Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIS Policy 5.1.1 - disallow clusterrole binding to cluster-admin #32

Merged
merged 3 commits into from
Jun 12, 2020

Conversation

saurabhpandit
Copy link
Contributor

Signed-off-by: Saurabh Pandit [email protected]

Description

Implementing CIS Kubernetes Benchmark 1.5.1 policy 5.1.1

Type Of Change

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Docs
  • Installation
  • Performance and Scalability
  • Security
  • Test and/or Release
  • User Experience

Issue Ref (Optional)

Fixes #26

Notes

Add special notes for your reviewer here.

Copy link
Owner

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, did you want to leave the traces in-line, or is it safe to remove them?

Repository owner deleted a comment from github-actions bot Jun 11, 2020
xunholy
xunholy previously approved these changes Jun 11, 2020
Copy link
Owner

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Can add the RoleBinding scenario in another PR if you'd like. Good work!

Copy link
Owner

@xunholy xunholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@saurabhpandit saurabhpandit merged commit b3219e1 into master Jun 12, 2020
@saurabhpandit saurabhpandit deleted the feature/#26-cis-benchmark-5-1 branch June 12, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIS Kubernetes Benchmark 1.5.1 # 5.1
2 participants