Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add development rule #37

Merged
merged 2 commits into from
Dec 16, 2017
Merged

Conversation

Asuforce
Copy link
Contributor

何を解決するのか

ref: #9
開発ガイドラインを作成したので、README.md にリンクを作成します

レビューポイント

  • 開発ガイドラインの内容も確認お願いします〜

@Asuforce Asuforce self-assigned this Dec 16, 2017
@Asuforce
Copy link
Contributor Author

@xpjp/ruby-reviewer レビューお願いします〜

Copy link
Contributor

@mc-chinju mc-chinju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リンク先の開発ガイドラインも確認しました。

LGTM です 👍

Copy link
Contributor

@toshikidoi toshikidoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
開発ガイドライン含めて、LGTMです🎉

@chipstar
Copy link
Contributor

README.mdがコンフリクトしてるみたいですー

@chipstar chipstar merged commit 93b83bb into master Dec 16, 2017
@Asuforce Asuforce deleted the update-readme-about-development-rule branch December 16, 2017 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants