clippy fixes

src/app/components/login/login.rs

@@ -6,7 +6,7 @@ use url::Url;
 
 use crate::app::components::EventListener;
 use crate::app::state::{LoginEvent, LoginStartedEvent};
-use crate::app::{AppEvent, Worker};
+use crate::app::AppEvent;
 
 use super::LoginModel;
 mod imp {
@@ -93,11 +93,10 @@ pub struct Login {
     parent: gtk::Window,
     login_window: LoginWindow,
     model: Rc<LoginModel>,
-    worker: Worker,
 }
 
 impl Login {
-    pub fn new(parent: gtk::Window, model: LoginModel, worker: Worker) -> Self {
+    pub fn new(parent: gtk::Window, model: LoginModel) -> Self {
         let model = Rc::new(model);
 
         let login_window = LoginWindow::new();
@@ -116,7 +115,6 @@ impl Login {
             parent,
             login_window,
             model,
-            worker,
         }
     }
 
@@ -140,7 +138,7 @@ impl Login {
     }
 
     fn open_login_url(&self, url: Url) {
-        if let Err(_) = open::that(url.as_str()) {
+        if open::that(url.as_str()).is_err() {
             warn!("Could not open login page");
         }
     }

src/app/mod.rs

@@ -98,7 +98,7 @@ impl App {
                 dispatcher.box_clone(),
                 worker.clone(),
             ),
-            App::make_login(builder, dispatcher.box_clone(), worker.clone()),
+            App::make_login(builder, dispatcher.box_clone()),
             App::make_navigation(
                 builder,
                 Rc::clone(model),
@@ -179,14 +179,10 @@ impl App {
         ))
     }
 
-    fn make_login(
-        builder: &gtk::Builder,
-        dispatcher: Box<dyn ActionDispatcher>,
-        worker: Worker,
-    ) -> Box<Login> {
+    fn make_login(builder: &gtk::Builder, dispatcher: Box<dyn ActionDispatcher>) -> Box<Login> {
         let parent: gtk::Window = builder.object("window").unwrap();
         let model = LoginModel::new(dispatcher);
-        Box::new(Login::new(parent, model, worker))
+        Box::new(Login::new(parent, model))
     }
 
     fn make_selection_toolbar(

src/player/oauth2.rs

@@ -80,17 +80,14 @@ impl SpotOauthClient {
 
     pub async fn spawn_authcode_listener(
         &self,
-        notify_complete: impl FnOnce() -> () + 'static,
+        notify_complete: impl FnOnce() + 'static,
     ) -> Result<AuthcodeChallenge, OAuthError> {
         let (pkce_challenge, pkce_verifier) = PkceCodeChallenge::new_random_sha256();
 
         // Generate the full authorization URL.
         // Some of these scopes are unavailable for custom client IDs. Which?
-        let request_scopes: Vec<oauth2::Scope> = SCOPES
-            .split(",")
-            .into_iter()
-            .map(|s| Scope::new(s.into()))
-            .collect();
+        let request_scopes: Vec<oauth2::Scope> =
+            SCOPES.split(",").map(|s| Scope::new(s.into())).collect();
 
         let (auth_url, csrf_token) = self
             .client