Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: copy_to supports aio files #32

Merged
merged 5 commits into from
Jul 5, 2023
Merged

ENH: copy_to supports aio files #32

merged 5 commits into from
Jul 5, 2023

Conversation

ChengjieLi28
Copy link
Contributor

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Jun 29, 2023
@XprobeBot XprobeBot added this to the v0.0.6 milestone Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023 •
edited
Loading

Codecov Report

Merging #32 (2b628f3) into main (5dd2fa7) will decrease coverage by 0.04%.
The diff coverage is 97.56%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   93.66%   93.63%   -0.04%     
==========================================
  Files          42       42              
  Lines        3332     3361      +29     
  Branches      668      672       +4     
==========================================
+ Hits         3121     3147      +26     
- Misses        140      141       +1     
- Partials       71       73       +2
Flag Coverage Δ
unittests 93.48% <97.56%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/context.py 94.17% <97.05%> (+0.24%) ⬆️
python/xoscar/backends/pool.py 95.94% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

@ChengjieLi28 ChengjieLi28 marked this pull request as ready for review June 29, 2023 04:56
codingl2k1
codingl2k1 reviewed Jul 3, 2023
View reviewed changes
Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use sendfile to optimize performance on the Linux platform and add an asv benchmark.

python/xoscar/context.pyx Show resolved Hide resolved
python/xoscar/core.pyx Outdated Show resolved Hide resolved
python/xoscar/core.pyx Outdated Show resolved Hide resolved
@ChengjieLi28
Copy link
Contributor Author

Maybe we can use sendfile to optimize performance on the Linux platform and add an asv benchmark.

Sure. Here's an issue #34 . Will have another PR later.

codingl2k1
codingl2k1 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aresnow1
aresnow1 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 1ea9836 into xorbitsai:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingl2k1 codingl2k1 codingl2k1 approved these changes

@aresnow1 aresnow1 aresnow1 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@ChengjieLi28 @aresnow1 @codingl2k1 @XprobeBot