Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Support tcp store for rendezvous in collective communication #31

Merged
merged 19 commits into from
Jul 4, 2023
Merged

FEAT: Support tcp store for rendezvous in collective communication #31

merged 19 commits into from
Jul 4, 2023

Conversation

ChengjieLi28
Copy link
Contributor

Related #22

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.0.6 milestone Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #31 (4a7482a) into main (5dd2fa7) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   93.66%   93.64%   -0.02%     
==========================================
  Files          42       43       +1     
  Lines        3332     3370      +38     
  Branches      668      671       +3     
==========================================
+ Hits         3121     3156      +35     
- Misses        140      143       +3     
  Partials       71       71
Flag Coverage Δ
unittests 93.50% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oscar/collective/rendezvous/test/test_tcp_store.py 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@ChengjieLi28 ChengjieLi28 marked this pull request as ready for review June 28, 2023 06:24
codingl2k1
codingl2k1 reviewed Jul 4, 2023
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
codingl2k1
codingl2k1 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aresnow1
aresnow1 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChengjieLi28 ChengjieLi28 merged commit 9537f54 into xorbitsai:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingl2k1 codingl2k1 codingl2k1 approved these changes

@aresnow1 aresnow1 aresnow1 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@ChengjieLi28 @aresnow1 @codingl2k1 @XprobeBot