-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix media link classes not being added #435
Conversation
Tests are failing because the class attribute is now appearing before the |
There is a SpecFileGen project in the solutuion. Running that will regenerate the test code |
Can you also add a test case to emphasize the specific case this PR is fixing |
The thing is, the Bootstrap extension adding |
I'm currently running into nunit/nunit3-vs-adapter#691 and I'm unable to run most tests in Visual Studio. I'll commit them but I have no idea if they'll pass, I guess we'll see. |
Does it work if you run them from the command line with |
That works, thanks. It seems they pass! |
I noticed this when using both the Bootstrap extension and the Media Links extension. When Bootstraps adds
img-fluid
, the Media Link extension didn't add their classes as well. This PR should fix that.