Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media link classes not being added #435

Merged
merged 5 commits into from
Jun 9, 2020
Merged

Fix media link classes not being added #435

merged 5 commits into from
Jun 9, 2020

Conversation

RudeySH
Copy link
Contributor

@RudeySH RudeySH commented May 12, 2020

I noticed this when using both the Bootstrap extension and the Media Links extension. When Bootstraps adds img-fluid, the Media Link extension didn't add their classes as well. This PR should fix that.

@RudeySH
Copy link
Contributor Author

RudeySH commented May 12, 2020

Tests are failing because the class attribute is now appearing before the width and height attributes. I've already fixed this in TestMediaLinks.cs but I just noticed MediaSpecs.md and the unit test file that appears to get generated by that markdown file. When modifying these Specs .md files, how do I regenerate the *.generated.cs file along with it?

@MihaZupan
Copy link
Collaborator

There is a SpecFileGen project in the solutuion. Running that will regenerate the test code

@MihaZupan
Copy link
Collaborator

Can you also add a test case to emphasize the specific case this PR is fixing

@RudeySH
Copy link
Contributor Author

RudeySH commented May 12, 2020

The thing is, the Bootstrap extension adding img-fluid to embeds doesn't actually make sense. I'll add some tests but they'll have to be changed if #434 gets resolved.

@RudeySH
Copy link
Contributor Author

RudeySH commented May 12, 2020

I'm currently running into nunit/nunit3-vs-adapter#691 and I'm unable to run most tests in Visual Studio. I'll commit them but I have no idea if they'll pass, I guess we'll see.

@MihaZupan
Copy link
Collaborator

Does it work if you run them from the command line with dotnet test?

@RudeySH
Copy link
Contributor Author

RudeySH commented May 12, 2020

That works, thanks. It seems they pass!

@xoofx xoofx merged commit 0545faa into xoofx:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants