Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated pipes module with shlex.quote #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sterliakov
Copy link

@sterliakov sterliakov commented Oct 23, 2023

pipes.quote is undocumented. It is mentioned in 2.7 docs as deprecated and exported as shlex.quote. Now whole pipes module is deprecated as of 3.11 and scheduled for removal in python 3.13.

Currently using executor results in a deprecation warning:

../../.venv/lib/python3.11/site-packages/executor/__init__.py:47
  /.venv/lib/python3.11/site-packages/executor/__init__.py:47: DeprecationWarning: 'pipes' is deprecated and slated for removal in Python 3.13
    import pipes

@elementalvoid
Copy link

@sterliakov 👋. Sorry, I looked for a fix for this a couple of weeks ago and your PR didn't exist yet. When I implemented #22 today I didn't check in again before doing so!

I'm not sure if @xolox has any desire to maintain 2.7 compatibility but that's the main difference between our two PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants