Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix explicit vmod dump #595

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

wismill
Copy link
Member

@wismill wismill commented Jan 15, 2025

xkbcommon already allow pure virtual modifiers (see #450) via explicit mapping (see @mahkoh comment). But it does not roundtrip, because we do not dump the virtual modifier mappings.

This PR enable dumping the explicit mappings. The following issue may be dealt with in a follow-up MR:

The assignment of pure virtual modifiers to bits is implicit. If both parties don't agree on the order in which virtual modifiers are assigned, they cannot communicate. With the mapping explicitly spelled out, it is at least possible for a client to detect the desired bit offset.

@wismill wismill added bug Indicates an unexpected problem or unintended behavior compile-keymap Indicates a need for improvements or additions to keymap compilation labels Jan 15, 2025
@wismill wismill force-pushed the mods/fix-explicit-vmod-dump branch from 51b410b to e19df74 Compare January 15, 2025 18:13
@wismill wismill mentioned this pull request Jan 15, 2025
3 tasks
@wismill wismill changed the title Mods/fix explicit vmod dump Fix explicit vmod dump Jan 15, 2025
@wismill wismill added this to the 1.8.0 milestone Jan 15, 2025
@wismill wismill force-pushed the mods/fix-explicit-vmod-dump branch 2 times, most recently from 2137bc2 to 17c3811 Compare January 17, 2025 18:21
@wismill wismill force-pushed the mods/fix-explicit-vmod-dump branch from 17c3811 to 98098da Compare January 17, 2025 20:02
@wismill wismill merged commit 8d0df44 into xkbcommon:master Jan 17, 2025
4 checks passed
@wismill wismill deleted the mods/fix-explicit-vmod-dump branch January 17, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior compile-keymap Indicates a need for improvements or additions to keymap compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant