Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x11: Keep level when the keysym is undefined but not the action #590

Merged
merged 1 commit into from
Jan 11, 2025
Merged

x11: Keep level when the keysym is undefined but not the action #590

merged 1 commit into from
Jan 11, 2025

Conversation

wismill
Copy link
Member

@wismill wismill commented Jan 11, 2025

When getting the keymap from X11, the following:

key <AD01> { actions=[SetGroup(2)] };

is currently converted to:

key <AD01> { };

This commit fixes dropping a defined action when the keysym is undefined

@wismill
x11: Keep level when the keysym is undefined but not the action
1fda13d 
When getting the keymap from X11, the following:

```
key <AD01> { actions=[SetGroup(2)] };
```

is currently converted to:

```
key <AD01> { };
```

This commit fixes dropping a defined action when the keysym is undefined
@wismill wismill added bug Indicates an unexpected problem or unintended behavior X11 legacy: compatibility Indicate a need to ensure compatibility with X11 labels Jan 11, 2025
@wismill wismill added this to the 1.8.0 milestone Jan 11, 2025
@wismill wismill merged commit 93b75c6 into xkbcommon:master Jan 11, 2025
4 checks passed
@wismill wismill deleted the x11/fix-actions branch January 11, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior X11 legacy: compatibility Indicate a need to ensure compatibility with X11
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@wismill